All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Ted Pavlic <ted@tedpavlic.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/2] completion: Get rid of tabbed indentation in comments. Replace with spaces.
Date: Fri, 6 Feb 2009 08:13:03 -0800	[thread overview]
Message-ID: <20090206161303.GP26880@spearce.org> (raw)
In-Reply-To: <1233936338-10679-2-git-send-email-ted@tedpavlic.com>

Ted Pavlic <ted@tedpavlic.com> wrote:
> Signed-off-by: Ted Pavlic <ted@tedpavlic.com>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>

Heh.

I expected Junio to use my TAB line as-is.  I find them amusing.
Plus, I didn't actually apply your patches and test them.  They
just looked right to me.  Usually Acked-by is applied only if you
actually ran the code and verified it does what the message claims.
Trivially-acked-by is a bit less strict.

Whatever.  These are really trivial patches.  Whatever Junio
applies here is fine.

Thanks for fixing that ${X-} thing.  I clearly missed it on the
review of the ps1 stuff.

-- 
Shawn.

  reply	other threads:[~2009-02-06 16:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-06 15:46 [PATCH 0/2] completion: Fixes GIT_PS1_SHOWDIRTYSTATE problems Ted Pavlic
2009-02-06 15:46 ` [PATCH 1/2] completion: Fix GIT_PS1_SHOWDIRTYSTATE to prevent unbound variable errors Ted Pavlic
2009-02-06 15:46   ` [PATCH 2/2] completion: Get rid of tabbed indentation in comments. Replace with spaces Ted Pavlic
2009-02-06 15:58     ` Shawn O. Pearce
2009-02-06 16:05       ` [PATCH 1/2] completion: Fix GIT_PS1_SHOWDIRTYSTATE to prevent unbound variable errors Ted Pavlic
2009-02-06 16:05         ` [PATCH 2/2] completion: Get rid of tabbed indentation in comments. Replace with spaces Ted Pavlic
2009-02-06 16:13           ` Shawn O. Pearce [this message]
2009-02-06 16:19             ` Ted Pavlic
2009-02-06 23:32             ` Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090206161303.GP26880@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ted@tedpavlic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.