From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756006AbZBFSk1 (ORCPT ); Fri, 6 Feb 2009 13:40:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752795AbZBFSkR (ORCPT ); Fri, 6 Feb 2009 13:40:17 -0500 Received: from pfepa.post.tele.dk ([195.41.46.235]:47297 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbZBFSkQ (ORCPT ); Fri, 6 Feb 2009 13:40:16 -0500 Date: Fri, 6 Feb 2009 19:42:05 +0100 From: Sam Ravnborg To: Jaswinder Singh Rajput Cc: Ingo Molnar , Linus Torvalds , Tony Luck , Andrew Morton , Russell King - ARM Linux , hskinnemoen@atmel.com, cooloney@kernel.org, ralf@linux-mips.org, dhowells@redhat.com, matthew@wil.cx, chris@zankel.net, LKML Subject: Re: [git pull -tip] headers_check fixes for other architectures Message-ID: <20090206184205.GA11879@uranus.ravnborg.org> References: <1233385816.17794.16.camel@localhost.localdomain> <12c511ca0902050955x1acb3907jdbfc1d0e6392cb91@mail.gmail.com> <20090205191907.GA27422@elte.hu> <1233886017.3463.26.camel@localhost.localdomain> <20090206022025.GA8317@elte.hu> <1233929922.3209.6.camel@localhost.localdomain> <20090206172453.GB11299@uranus.ravnborg.org> <1233943912.3209.90.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1233943912.3209.90.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Subject: [PATCH] make linux/types.h as assembly safe > > Signed-off-by: Jaswinder Singh Rajput > --- > include/linux/types.h | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/include/linux/types.h b/include/linux/types.h > index 712ca53..e1322a7 100644 > --- a/include/linux/types.h > +++ b/include/linux/types.h > @@ -1,6 +1,10 @@ > #ifndef _LINUX_TYPES_H > #define _LINUX_TYPES_H > > +#ifdef __ASSEMBLY__ > +# include > +#else /* __ASSEMBLY__ */ Please use: #ifndef __ASEMBLY__ This is what is used in the most cases. And I think you need to nuke an include in the file a bit later so we do not include asm/types.h twice. Sam