From: Ondrej Zary <linux@rainbow-software.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [resend] Resume from hibernation fails with pata_it821x RAID volume
Date: Sat, 7 Feb 2009 13:29:58 +0100 [thread overview]
Message-ID: <200902071330.00779.linux@rainbow-software.org> (raw)
In-Reply-To: <20090206175635.5344ce37@lxorguk.ukuu.org.uk>
On Friday 06 February 2009 18:56:35 Alan Cox wrote:
> > See CodingStyle chapter 8 for the preferred multiline comment style.
> >
> > > + memset(&id[ATA_ID_SERNO], 0x20, ATA_ID_SERNO_LEN);
> >
> > Why not ' '?
> >
> > MBR, Sergei
>
> Digging into the docs the RAID serial number (and what that means isn't
> defined anywhere I can see) is byte offset 54-73 in each of the 4 128
> byte blocks returned by the chip status query we do at boot
> (it821x_probe_firmware).
Yes, found it there. But it seems to be the same number as present in the
IDENTIFY data. It contains date and time of boot (matches RAID_SERIAL_NUMBER
structure found in iteraid.h in driver source from ITE) instead of date and
time of RAID creation.
--
Ondrej Zary
next prev parent reply other threads:[~2009-02-07 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 13:12 [PATCH] [resend] Resume from hibernation fails with pata_it821x RAID volume Ondrej Zary
2009-02-06 17:46 ` Sergei Shtylyov
2009-02-06 17:56 ` Alan Cox
2009-02-07 12:29 ` Ondrej Zary [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-09 17:05 Ondrej Zary
2009-02-03 22:20 Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902071330.00779.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.