From: Adam Baker <linux@baker-net.org.uk>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-media@vger.kernel.org, Olivier Lorin <o.lorin@laposte.net>,
Hans de Goede <j.w.r.degoede@hhs.nl>,
kilgota@banach.math.auburn.edu,
"Jean-Francois Moine" <moinejf@free.fr>
Subject: libv4l and HFLIP / VFLIP again
Date: Sat, 7 Feb 2009 17:15:24 +0000 [thread overview]
Message-ID: <200902071715.24282.linux@baker-net.org.uk> (raw)
Hi All,
Now that the SQ-905 driver has been accepted into the gspca tree it is time to
consider how best to address passing the sensor orientation from the driver
to libv4l.
For this camera the approach taken so far of knowing what orientation is
needed based on the USB ID won't work as there are variants of the camera
with different sensor orientation but the same ID. The driver can detect this
based on some initialisation messages but needs to tell libv4l.
For SQ-905 the orientation will remain fixed but we know there exist cameras
that provide some form of tilt switch to detect orientation so the adopted
solution should be able to cope with those too.
Olivier Lorin has proposed a solution to this problem that involves using 2
new bits in v4l2_buffer->flags and has offered a patch for libv4l to add
support for the 180 degree rotation case.
Does anyone have a suggestion for a better way to address this problem? If not
I'll prepare a patch to add the flags to include/linux/videodev2.h and one to
set them in sq905.c.
After that I'll work on expanding Olivier Lorin's patch to
1) Ignore the flag from the driver for cameras listed in v4lconvert_flags
(otherwise as the kernel driver doesn't currently set the flag for those
cameras the change would be incompatible with current kernels for those
cameras).
2) support independent setting of HFLIP and VFLIP (some SQ-905 cameras need
only VFLIP).
And finally add the flags in the kernel drivers for the cameras listed in
v4lconvert_flags so that eventually (once we are confident no-one running
2.6.29 will want a new libv4l) that functionality can be removed from libv4l.
What is the preferred version of libv4l to prepare patches against? Is it
http://linuxtv.org/hg/~hgoede/v4l-dvb
Adam Baker
next reply other threads:[~2009-02-07 17:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 17:15 Adam Baker [this message]
2009-02-07 17:54 ` libv4l and HFLIP / VFLIP again Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902071715.24282.linux@baker-net.org.uk \
--to=linux@baker-net.org.uk \
--cc=hdegoede@redhat.com \
--cc=j.w.r.degoede@hhs.nl \
--cc=kilgota@banach.math.auburn.edu \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=o.lorin@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.