From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Thiemo Nagel <thiemo.nagel@ph.tum.de>
Cc: Theodore Tso <tytso@mit.edu>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] introduce range check for extent pblock references
Date: Sat, 7 Feb 2009 23:02:39 +0530 [thread overview]
Message-ID: <20090207173239.GA25942@skywalker> (raw)
In-Reply-To: <498DAA9A.8030309@ph.tum.de>
On Sat, Feb 07, 2009 at 04:36:58PM +0100, Thiemo Nagel wrote:
> This time I have aimed to catch all cases in which an invalid physical
> block might be used and implemented checks directly in ext_pblock() and
> idx_pblock() following the assumption that most of the times one of
> these functions is called a device access to that address will follow.
> If you think this is too heavy, I could also split the check from the
> pblock calculation, but in that case I could only guess at which of the
> several accesses to *_pblock() in extents.c a check would be necessary
> and where it wouldn't and there would be the possibility of missing
> something.
Do we want to check for validity every time we look at the physical
block of the extent. I guess that would be bad performance wise. I guess
we should check only once when we read the extent from the disk. ??
-aneesh
next prev parent reply other threads:[~2009-02-07 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 15:36 [PATCH] introduce range check for extent pblock references Thiemo Nagel
2009-02-07 17:32 ` Aneesh Kumar K.V [this message]
2009-02-07 18:49 ` Thiemo Nagel
2009-02-07 19:59 ` Aneesh Kumar K.V
2009-02-07 20:01 ` [PATCH] Add checks to validate extent entries Aneesh Kumar K.V
2009-02-07 20:01 ` [PATCH] Validate extent details only when read from the disk Aneesh Kumar K.V
2009-02-09 10:31 ` Thiemo Nagel
2009-02-09 10:48 ` Aneesh Kumar K.V
2009-02-09 11:12 ` Thiemo Nagel
2009-02-09 10:26 ` [PATCH] Add checks to validate extent entries Thiemo Nagel
2009-02-09 10:31 ` Aneesh Kumar K.V
2009-02-09 10:40 ` Thiemo Nagel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090207173239.GA25942@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=thiemo.nagel@ph.tum.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.