hfs patch (Re: State of GRUB on PowerPC)

[Robert Millan <rmh@aybabtu.com>]

On Tue, Jan 27, 2009 at 08:19:41AM +0100, Michel Dänzer wrote:
> +/*
> + * unsigned char caseorder[]
> + *
> + * Defines the lexical ordering of characters on the Macintosh
> + *
> + * Composition of the 'casefold' and 'order' tables from ARDI's code
> + * with the entry for 0x20 changed to match that for 0xCA to remove
> + * special case for those two characters.
> + */
> +static unsigned char caseorder[256] = {
> +	0x00,0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08,0x09,0x0A,0x0B,0x0C,0x0D,0x0E,0x0F,

Could you be more specific about what the table contents mean?

> +  for (i = 0; i < k1->strlen && i < k2->strlen; i++) {
> +    cmp = caseorder[k1->str[i]] - caseorder[k2->str[i]];

I think "a = (b != c)" would be more efficient (and also work).

Also please add a newline before operning braces ({).

Thanks!

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."