From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LVvnK-0007z6-Ku for mharc-grub-devel@gnu.org; Sat, 07 Feb 2009 17:37:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVvnI-0007wj-GI for grub-devel@gnu.org; Sat, 07 Feb 2009 17:37:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVvnH-0007vq-QT for grub-devel@gnu.org; Sat, 07 Feb 2009 17:36:59 -0500 Received: from [199.232.76.173] (port=49789 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVvnH-0007vf-B9 for grub-devel@gnu.org; Sat, 07 Feb 2009 17:36:59 -0500 Received: from aybabtu.com ([69.60.117.155]:46607) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LVvnG-000554-RX for grub-devel@gnu.org; Sat, 07 Feb 2009 17:36:59 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1LVvi4-0006Kh-Hp for grub-devel@gnu.org; Sat, 07 Feb 2009 23:31:36 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1LVvmm-0002LE-Tn for grub-devel@gnu.org; Sat, 07 Feb 2009 23:36:28 +0100 Date: Sat, 7 Feb 2009 23:36:28 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090207223628.GQ6343@thorin> References: <498983B3.8090904@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <498983B3.8090904@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Remove trailing space from FAT label X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Feb 2009 22:37:00 -0000 On Wed, Feb 04, 2009 at 01:01:55PM +0100, phcoder wrote: > Hello. Here is the patch to remove trailing spaces from FAT label. These > spaces generally aren't considiered to be part of label > Thanks > Vladimir 'phcoder' Serbinenko > Index: fs/fat.c > =================================================================== > --- fs/fat.c (revision 1973) > +++ fs/fat.c (working copy) > @@ -809,7 +809,13 @@ > > if (dir.attr == GRUB_FAT_ATTR_VOLUME_ID) > { > - *label = grub_strndup ((char *) dir.name, 11); > + int labellen = 0, i; > + for (i = 0; i < 11; i++) Please use a descriptive macro instead of hardcoding 11. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."