From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LVw9U-0003wU-R9 for mharc-grub-devel@gnu.org; Sat, 07 Feb 2009 17:59:56 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVw9S-0003t5-DN for grub-devel@gnu.org; Sat, 07 Feb 2009 17:59:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVw9Q-0003r3-VC for grub-devel@gnu.org; Sat, 07 Feb 2009 17:59:54 -0500 Received: from [199.232.76.173] (port=49547 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVw9Q-0003qk-N4 for grub-devel@gnu.org; Sat, 07 Feb 2009 17:59:52 -0500 Received: from aybabtu.com ([69.60.117.155]:49639) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LVw9Q-0006qK-Al for grub-devel@gnu.org; Sat, 07 Feb 2009 17:59:52 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1LVw4D-0006MX-Q2 for grub-devel@gnu.org; Sat, 07 Feb 2009 23:54:30 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1LVw8v-0002b4-P1 for grub-devel@gnu.org; Sat, 07 Feb 2009 23:59:21 +0100 Date: Sat, 7 Feb 2009 23:59:21 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090207225921.GX6343@thorin> References: <497B9D35.5010703@t-online.de> <20090207213813.GF6343@thorin> <498E0F4F.6000503@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <498E0F4F.6000503@t-online.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] hdparm.mod - get/set ATA disk parameters X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Feb 2009 22:59:55 -0000 On Sat, Feb 07, 2009 at 11:46:39PM +0100, Christian Franke wrote: > Robert Millan wrote: > >On Sat, Jan 24, 2009 at 11:59:01PM +0100, Christian Franke wrote: > > > >>This patch adds a command which allows to change a few (S)ATA drive > >>settings. It relies on a new pass-through function in ata.mod. > >> > > > >Is this function going to be used for "normal" use of ata? Note that > >ata.mod > >should be as small as possible, since coreboot users usually want to > >include > >it the GRUB that is installed to flash. > > > > > > Like 'hdparm.mod' itself, the ATA pass-through function is not needed > for normal boot. Well, I know it's not needed, but I was wondering if there's the possibility that other functions in ata.mod could start using it later on, or so. > I would suggest to move grub_ata_pass_through() to a new module (e.g. > ata2.mod, atax.mod, ataex.mod, ...) How about ata_something.mod? (consistent with ntfs.mod & ntfs_comp.mod) -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."