From: Matthew Wilcox <matthew@wil.cx>
To: Pavel Fedin <sonic.amiga@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 4/9] Amiga SmartFileSystem
Date: Mon, 9 Feb 2009 01:40:13 -0700 [thread overview]
Message-ID: <20090209084013.GM31509@parisc-linux.org> (raw)
In-Reply-To: <187c6cc60902082255l1475ac1al80b8fc7e206b0bf2@mail.gmail.com>
On Mon, Feb 09, 2009 at 09:55:00AM +0300, Pavel Fedin wrote:
> + if ((errorcode = asfs_allocadminspace(sb,
> &newbcontblock)) == 0 && (bh = asfs_getzeroblk(sb, newbcontblock))) {
> + struct fsBNodeContainer *bnc = (void
> *) bh->b_data;
> + struct fsBNodeContainer *bncparent =
> (void *) bhparent->b_data;
> + struct BTreeContainer *btcparent =
> &bncparent->btc;
The wrapping aside, this level of indentation makes it almost impossible
to review. Generally, lines should be kept under 80 columns. This
particular function looks like it should be split into some helper
functions, but it's hard to be constructive when it's so hard to read.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2009-02-09 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 6:55 [PATCH 4/9] Amiga SmartFileSystem Pavel Fedin
2009-02-09 8:40 ` Matthew Wilcox [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-26 12:08 Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209084013.GM31509@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sonic.amiga@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.