From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5][RESEND] tracing/function-graph-tracer: drop the kernel_text_address check
Date: Mon, 9 Feb 2009 10:53:43 +0100 [thread overview]
Message-ID: <20090209095343.GE14402@elte.hu> (raw)
In-Reply-To: <498e1784.1438560a.641c.2d82@mx.google.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> When the function graph tracer picks a return address, it ensures this address
> is really a kernel text one by calling __kernel_text_address()
> Actually this path has never been taken. Its role was more likely to debug the tracer
> on the beginning of its development but this function is wasteful since it is called
> for every traced function.
>
> The fault check is already sufficient.
>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> arch/x86/kernel/ftrace.c | 7 -------
> kernel/extable.c | 4 ++--
> kernel/module.c | 2 +-
> 3 files changed, 3 insertions(+), 10 deletions(-)
Applied to tip/tracing/ftrace, thanks Frederic!
Ingo
prev parent reply other threads:[~2009-02-09 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 23:04 [PATCH 5/5][RESEND] tracing/function-graph-tracer: drop the kernel_text_address check Frederic Weisbecker
2009-02-09 9:53 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209095343.GE14402@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.