Re: [PATCH 1/2] ring_buffer: fix typing mistake

[Ingo Molnar <mingo@elte.hu>]

* Steven Rostedt <rostedt@goodmis.org> wrote:

> 
> On Mon, 9 Feb 2009, Lai Jiangshan wrote:
> 
> > 
> > Impact: Fix bug
> > 
> > I found several very very curious line.
> > It's so curious that it may be brought by typing mistake.
> > 
> > When (cpu_buffer->reader_page == cpu_buffer->commit_page):
> > 
> > 1) We haven't copied it for bpage is changed:
> >    bpage = cpu_buffer->reader_page->page;
> >    memcpy(bpage->data, cpu_buffer->reader_page->page->data + read ... )
> > 2) We need update cpu_buffer->reader_page->read, but
> >    "cpu_buffer->reader_page += read;" is not right.
> 
> Ouch! That is a bug.
> 
> Ingo, this is an urgent fix. Want me to pull it in and send it off to you?

Please do, yes.

	Ingo