From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LWXIm-0007h4-N5 for mharc-grub-devel@gnu.org; Mon, 09 Feb 2009 09:40:00 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LWXIl-0007fc-89 for grub-devel@gnu.org; Mon, 09 Feb 2009 09:39:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LWXIk-0007ei-Gt for grub-devel@gnu.org; Mon, 09 Feb 2009 09:39:58 -0500 Received: from [199.232.76.173] (port=60690 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LWXIk-0007ed-C1 for grub-devel@gnu.org; Mon, 09 Feb 2009 09:39:58 -0500 Received: from aybabtu.com ([69.60.117.155]:49479) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LWXIj-0003qE-Tu for grub-devel@gnu.org; Mon, 09 Feb 2009 09:39:58 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1LWXDN-0001cm-EM for grub-devel@gnu.org; Mon, 09 Feb 2009 15:34:25 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1LWXIE-0001T4-SC for grub-devel@gnu.org; Mon, 09 Feb 2009 15:39:26 +0100 Date: Mon, 9 Feb 2009 15:39:26 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090209143926.GB4841@thorin> References: <20090121211706.GA4175@pina.cat> <20090124142604.GB27695@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090124142604.GB27695@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: gettext patch (beta) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2009 14:39:59 -0000 Hi Carles On Sat, Jan 24, 2009 at 03:26:04PM +0100, Carles Pina i Estany wrote: > Index: Makefile.in > =================================================================== > --- Makefile.in (revision 1954) > +++ Makefile.in (working copy) > @@ -112,6 +112,7 @@ > PKGDATA = $(pkgdata_DATA) $(pkgdata_SRCDIR) > PROGRAMS = $(bin_UTILITIES) $(sbin_UTILITIES) > SCRIPTS = $(bin_SCRIPTS) $(sbin_SCRIPTS) $(grub-mkconfig_SCRIPTS) > +GRUBD = $(srcdir)/util/grub.d If you're adding GRUBD, perhaps you can use it in other places that currently hardcode "util/grub.d". > +"Content-Type: text/plain; charset=CHARSET\n" That should be charset=utf-8 > +" Presioneu retorn per arrancar el SO seleccionat, 'e' editar\n" "l'SO" ;-) > +" les comandes abans d'arrancar, 'c' per línia d'ordres." The 'í' should be in utf-8 (it displays in utf-8 here because your mailer set Content-Type to iso-8859-1). > +#: util/grub.d/10_linux.in:148 > +#, sh-format > +msgid "${OS}, linux ${version} (single-user mode)" > +msgstr "${OS}, linux ${version} (mode mono-usuari)" I wonder if we should replace the original string "single-user mode" with something else. Novice users find it confusing, since they may assume "single-user mode" is the normal mode for them (a single user) to use the computer. > + grub_free(current_string); > + min=current; > [...] > + current = (max+min)/2; Remember to add spaces in such places. > + if (magic != 0x950412de) This should be a macro. Also, it probably needs endian conversion (use the macros in types.h). > + /* Testing: > + grub_register_command ("_", grub_cmd_translate, GRUB_COMMAND_FLAG_BOTH, > + "_", "internalization support trans", 0); > + */ We could register the "gettext" command and leave it there by default. > +else > + echo "gettext module is not available" > +fi This should have ">&2", or it might end up as part of grub.cfg. Also it could be more descriptive (like, letting user know text output will be in English). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."