From: "Shawn O. Pearce" <spearce@spearce.org>
To: Yann Simon <yann.simon.fr@gmail.com>
Cc: Robin Rosenberg <robin.rosenberg.lists@dewire.com>,
git <git@vger.kernel.org>
Subject: Re: [PATCH JGIT] Add the signed-off in the commit text dialog
Date: Mon, 9 Feb 2009 07:58:18 -0800 [thread overview]
Message-ID: <20090209155818.GK30949@spearce.org> (raw)
In-Reply-To: <551f769b0902090750t2d6a43c4vb4944df340fc5148@mail.gmail.com>
Yann Simon <yann.simon.fr@gmail.com> wrote:
>
> And what should we do, when we commit a change from somebody else?
> Sould we be able to modify the signed-off of the author?
Well, not by a fancy UI widget and automated tools. But editing
the SBO line in the message buffer is fine, just like any other
part of the message.
IMHO, the SBO checkbox/button in the UI is only for *your* SBO,
as the committer. That's how git-gui behaves and it seems to
work out nicely.
--
Shawn.
prev parent reply other threads:[~2009-02-09 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 15:17 [PATCH JGIT] Add the signed-off in the commit text dialog Yann Simon
2009-02-09 15:46 ` Shawn O. Pearce
2009-02-09 15:50 ` Yann Simon
2009-02-09 15:58 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209155818.GK30949@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg.lists@dewire.com \
--cc=yann.simon.fr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.