From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LWZbD-0006ic-76 for mharc-grub-devel@gnu.org; Mon, 09 Feb 2009 12:07:11 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LWZbA-0006g7-QD for grub-devel@gnu.org; Mon, 09 Feb 2009 12:07:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LWZb9-0006e4-5o for grub-devel@gnu.org; Mon, 09 Feb 2009 12:07:07 -0500 Received: from [199.232.76.173] (port=33302 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LWZb9-0006dx-12 for grub-devel@gnu.org; Mon, 09 Feb 2009 12:07:07 -0500 Received: from aybabtu.com ([69.60.117.155]:56019) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LWZb8-0006OJ-Li for grub-devel@gnu.org; Mon, 09 Feb 2009 12:07:06 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1LWZVk-00026O-Ob for grub-devel@gnu.org; Mon, 09 Feb 2009 18:01:34 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1LWZaS-0006mX-AK for grub-devel@gnu.org; Mon, 09 Feb 2009 18:06:24 +0100 Date: Mon, 9 Feb 2009 18:06:24 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090209170623.GA26034@thorin> References: <1233866360.3426.31.camel@fz.local> <20090207225222.GU6343@thorin> <1234083823.3429.3.camel@fz.local> <20090209144029.GC4841@thorin> <1234190986.24013.6.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1234190986.24013.6.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] try to avoid false positives on FAT filesystem X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2009 17:07:09 -0000 On Mon, Feb 09, 2009 at 03:49:46PM +0100, Felix Zielcke wrote: > Am Montag, den 09.02.2009, 15:40 +0100 schrieb Robert Millan: > > > > > After your other commit, is this one still needed/useful? > > > Well my other commit just fixes the problem probable for these Dell > utiliti FAT partitions because they don't have a valid FAT16 string. > It could be still useful for the people who have a broken mkfs.ext2 > which doestn't zero out the first 512 bytes of the partition, but did > had a real valid FAT partition. > And I think it shouldn't hurt to check first for ext2 and then FAT. No objection from me. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."