From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] OCFS2: anti stale inode for nfs (V2).
Date: Mon, 9 Feb 2009 19:25:54 -0800 [thread overview]
Message-ID: <20090210032554.GF4341@mail.oracle.com> (raw)
In-Reply-To: <4990D968.1050703@oracle.com>
On Tue, Feb 10, 2009 at 09:33:28AM +0800, Wengang Wang wrote:
> one thing is that, the "nfs_sync_lock" will be one in count or more than
> one?
> I think having lots of this kind of lock(one for each meta block) will
> bring us least performance impact for deletions.
> well so much locks eat memory. for balancing, how about setting up 16(or
> 32) such locks? different inode goes to different lock according to its
> block number. and 16(or 32) such locks won't take much memory. --just
> like the idea in my original patch.
No, we'll have one lock per superblock. There's no performance
impact unless you have stale NFS clients. We take the lock in PR mode
in delete_inode, and the lock caching mechanism will keep it for us.
The lock will only be unlocked when a stale NFS client wants to lookup
its handle. Otherwise, all nodes will share the PR lock.
Joel
--
"Here's something to think about: How come you never see a headline
like ``Psychic Wins Lottery''?"
- Jay Leno
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2009-02-10 3:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 9:00 [Ocfs2-devel] [PATCH 1/1] OCFS2: anti stale inode for nfs (V2) wengang wang
2008-12-25 1:31 ` wengang wang
2009-01-30 1:11 ` Joel Becker
2009-02-10 1:33 ` Wengang Wang
2009-02-10 3:25 ` Joel Becker [this message]
2009-02-10 3:43 ` Wengang Wang
2009-02-10 4:14 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090210032554.GF4341@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.