From: David Brownell <david-b@pacbell.net>
To: Kalle Jokiniemi <kalle.jokiniemi@digia.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@sirena.org.uk>,
linux-usb@vger.kernel.org, OMAP <linux-omap@vger.kernel.org>
Subject: Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged
Date: Tue, 10 Feb 2009 11:52:59 -0800 [thread overview]
Message-ID: <200902101152.59526.david-b@pacbell.net> (raw)
In-Reply-To: <1234274767.17391.20.camel@ubuntu>
On Tuesday 10 February 2009, Kalle Jokiniemi wrote:
> > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1
> > when the USB cable is unplugged, to eliminate that source of power
> > waste. (Enabled LDOs consume power at all times.)
>
> Please put this on hold for a while. This won't work if we don't have
> TWL regulator support enabled.
So Kconfig should have TWL4030_USB depend on REGULATOR_TWL4030?
> Also it's missing error value checking.
You mean like in the ldo_init() stuff? Fair enough.
- Dave
> I'll post new patch(es) soon.
>
next prev parent reply other threads:[~2009-02-10 19:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 18:52 [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged David Brownell
2009-02-10 13:08 ` Kalle Jokiniemi
2009-02-10 15:19 ` Mark Brown
2009-02-10 15:19 ` Mark Brown
[not found] ` <200902081053.00255.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-10 14:06 ` Kalle Jokiniemi
2009-02-10 14:06 ` Kalle Jokiniemi
2009-02-10 19:52 ` David Brownell [this message]
[not found] ` <200902101152.59526.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-11 6:25 ` Kalle Jokiniemi
2009-02-26 22:16 ` Liam Girdwood
[not found] ` <1235686596.31223.106.camel-Pyf+wNJ1SdNifHs85vQuMtBc4/FLrbF6@public.gmane.org>
2009-02-26 22:40 ` David Brownell
2009-02-26 22:40 ` David Brownell
[not found] ` <200902261440.04129.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-27 6:19 ` Kalle Jokiniemi
2009-02-27 6:19 ` Kalle Jokiniemi
2009-02-27 12:29 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902101152.59526.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=broonie@sirena.org.uk \
--cc=kalle.jokiniemi@digia.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.