From: "K.Prasad" <prasad@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Roland McGrath <roland@redhat.com>,
mingo@elte.hu, richardj_moore@uk.ibm.com,
jason.wessel@windriver.com
Subject: [Patch 5/10] Use wrapper routines around debug registers in processor related functions
Date: Tue, 10 Feb 2009 18:12:16 +0530 [thread overview]
Message-ID: <20090210124216.GE14165@in.ibm.com> (raw)
In-Reply-To: <20090210123514.GA4199@in.ibm.com>
This patch enables the use of wrapper routines to access the debug/breakpoint
registers.
Signed-off-by: K.Prasad <prasad@linux.vnet.ibm.com>
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
---
arch/x86/kernel/smpboot.c | 3 +++
arch/x86/power/cpu_32.c | 16 +++-------------
arch/x86/power/cpu_64.c | 15 +++------------
3 files changed, 9 insertions(+), 25 deletions(-)
Index: mmotm/arch/x86/power/cpu_32.c
===================================================================
--- mmotm.orig/arch/x86/power/cpu_32.c
+++ mmotm/arch/x86/power/cpu_32.c
@@ -12,6 +12,7 @@
#include <asm/mtrr.h>
#include <asm/mce.h>
#include <asm/xcr.h>
+#include <asm/debugreg.h>
static struct saved_context saved_context;
@@ -47,6 +48,7 @@ static void __save_processor_state(struc
ctxt->cr2 = read_cr2();
ctxt->cr3 = read_cr3();
ctxt->cr4 = read_cr4_safe();
+ disable_debug_registers();
}
/* Needed by apm.c */
@@ -79,19 +81,7 @@ static void fix_processor_context(void)
load_TR_desc(); /* This does ltr */
load_LDT(¤t->active_mm->context); /* This does lldt */
- /*
- * Now maybe reload the debug registers
- */
- if (current->thread.debugreg7) {
- set_debugreg(current->thread.debugreg0, 0);
- set_debugreg(current->thread.debugreg1, 1);
- set_debugreg(current->thread.debugreg2, 2);
- set_debugreg(current->thread.debugreg3, 3);
- /* no 4 and 5 */
- set_debugreg(current->thread.debugreg6, 6);
- set_debugreg(current->thread.debugreg7, 7);
- }
-
+ load_debug_registers();
}
static void __restore_processor_state(struct saved_context *ctxt)
Index: mmotm/arch/x86/power/cpu_64.c
===================================================================
--- mmotm.orig/arch/x86/power/cpu_64.c
+++ mmotm/arch/x86/power/cpu_64.c
@@ -15,6 +15,7 @@
#include <asm/pgtable.h>
#include <asm/mtrr.h>
#include <asm/xcr.h>
+#include <asm/debugreg.h>
static void fix_processor_context(void);
@@ -70,6 +71,7 @@ static void __save_processor_state(struc
ctxt->cr3 = read_cr3();
ctxt->cr4 = read_cr4();
ctxt->cr8 = read_cr8();
+ disable_debug_registers();
}
void save_processor_state(void)
@@ -158,16 +160,5 @@ static void fix_processor_context(void)
load_TR_desc(); /* This does ltr */
load_LDT(¤t->active_mm->context); /* This does lldt */
- /*
- * Now maybe reload the debug registers
- */
- if (current->thread.debugreg7){
- loaddebug(¤t->thread, 0);
- loaddebug(¤t->thread, 1);
- loaddebug(¤t->thread, 2);
- loaddebug(¤t->thread, 3);
- /* no 4 and 5 */
- loaddebug(¤t->thread, 6);
- loaddebug(¤t->thread, 7);
- }
+ load_debug_registers();
}
Index: mmotm/arch/x86/kernel/smpboot.c
===================================================================
--- mmotm.orig/arch/x86/kernel/smpboot.c
+++ mmotm/arch/x86/kernel/smpboot.c
@@ -63,6 +63,7 @@
#include <asm/genapic.h>
#include <asm/setup.h>
#include <asm/uv/uv.h>
+#include <asm/debugreg.h>
#include <linux/mc146818rtc.h>
#include <mach_apic.h>
@@ -337,6 +338,7 @@ notrace static void __cpuinit start_seco
setup_secondary_clock();
wmb();
+ load_debug_registers();
cpu_idle();
}
@@ -1315,6 +1317,7 @@ void cpu_disable_common(void)
remove_cpu_from_maps(cpu);
unlock_vector_lock();
fixup_irqs();
+ disable_debug_registers();
}
int native_cpu_disable(void)
next prev parent reply other threads:[~2009-02-10 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 12:35 [Patch 0/10] Hardware Breakpoint interfaces - v2 K.Prasad
2009-02-10 12:40 ` [Patch 1/10] Introducing generic hardware breakpoint handler interfaces K.Prasad
2009-02-10 12:40 ` [Patch 2/10] x86 architecture implementation of Hardware Breakpoint interfaces K.Prasad
2009-02-10 12:41 ` [Patch 3/10] Modifying generic debug exception to use virtual debug registers K.Prasad
2009-02-10 12:41 ` [Patch 4/10] Introduce virtual debug register in thread_struct and wrapper-routines around process related functions K.Prasad
2009-02-10 12:42 ` K.Prasad [this message]
2009-02-10 12:42 ` [Patch 6/10] Use virtual debug registers in process/thread handling code K.Prasad
2009-02-10 12:43 ` [Patch 7/10] Modify signal handling code to refrain from re-enabling HW Breakpoints K.Prasad
2009-02-10 12:43 ` [Patch 8/10] Modify Ptrace routines to access breakpoint registers K.Prasad
2009-02-10 12:44 ` [Patch 9/10] Cleanup HW Breakpoint registers before kexec K.Prasad
2009-02-10 12:45 ` [Patch 10/10] Sample HW breakpoint over kernel data address K.Prasad
-- strict thread matches above, loose matches on Subject: below --
2009-02-15 10:30 [Patch 00/10] Hardware Breakpoint interfaces K.Prasad
2009-02-15 10:34 ` [Patch 5/10] Use wrapper routines around debug registers in processor related functions K.Prasad
2009-02-13 14:53 [Patch 00/10] Hardware Breakpoint interfaces K.Prasad
2009-02-13 14:56 ` [Patch 5/10] Use wrapper routines around debug registers in processor related functions K.Prasad
2009-01-29 7:48 [Patch 0/10] Hardware Breakpoint interfaces K.Prasad
2009-01-29 8:29 ` [Patch 5/10] Use wrapper routines around debug registers in processor related functions K.Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090210124216.GE14165@in.ibm.com \
--to=prasad@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=richardj_moore@uk.ibm.com \
--cc=roland@redhat.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.