All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Glauber de Oliveira Costa <gcosta@redhat.com>,
	kvm-devel <kvm@vger.kernel.org>
Subject: KVM: x86: disable kvmclock on non constant TSC hosts
Date: Tue, 10 Feb 2009 20:59:45 -0200	[thread overview]
Message-ID: <20090210225945.GA5373@amt.cnet> (raw)
In-Reply-To: <20090210172407.GA31394@amt.cnet>


This is better.

Currently, this code path is posing us big troubles,
and we won't have a decent patch in time. So, temporarily
disable it.
 
Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Index: kvm/arch/x86/kvm/x86.c
===================================================================
--- kvm.orig/arch/x86/kvm/x86.c
+++ kvm/arch/x86/kvm/x86.c
@@ -989,7 +989,6 @@ int kvm_dev_ioctl_check_extension(long e
 	case KVM_CAP_MMU_SHADOW_CACHE_CONTROL:
 	case KVM_CAP_SET_TSS_ADDR:
 	case KVM_CAP_EXT_CPUID:
-	case KVM_CAP_CLOCKSOURCE:
 	case KVM_CAP_PIT:
 	case KVM_CAP_NOP_IO_DELAY:
 	case KVM_CAP_MP_STATE:
@@ -1015,6 +1014,9 @@ int kvm_dev_ioctl_check_extension(long e
 	case KVM_CAP_IOMMU:
 		r = iommu_found();
 		break;
+	case KVM_CAP_CLOCKSOURCE:
+		r = boot_cpu_has(X86_FEATURE_CONSTANT_TSC);
+		break;
 	default:
 		r = 0;
 		break;


  reply	other threads:[~2009-02-10 23:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-10 17:24 KVM: x86: disable kvmclock on non constant TSC hosts Marcelo Tosatti
2009-02-10 22:59 ` Marcelo Tosatti [this message]
2009-02-11 12:01   ` Avi Kivity
2009-02-11 20:08     ` Mark McLoughlin
2009-02-11 22:55       ` Marcelo Tosatti
2009-02-12 10:02         ` Avi Kivity
2009-02-12 14:33           ` Mark McLoughlin
2009-02-12 16:29           ` Chris Wright
2009-02-12 16:35             ` Avi Kivity
2009-02-12 16:39               ` Chris Wright
2009-02-12 17:54                 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090210225945.GA5373@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@redhat.com \
    --cc=gcosta@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.