All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Takashi Iwai <tiwai@suse.de>, Shane W <shane-alsa@csy.ca>
Cc: alsa-devel@alsa-project.org, Wu Fengguang <fengguang.wu@intel.com>
Subject: [PATCH 1/4] hda - allow multi-channel HDMI audio playback when ELD is not present
Date: Wed, 11 Feb 2009 15:22:28 +0800	[thread overview]
Message-ID: <20090211073402.569527628@intel.com> (raw)
In-Reply-To: 20090211072227.760779741@intel.com

[-- Attachment #1: intel-hdmi-8channel.patch --]
[-- Type: text/plain, Size: 1306 bytes --]

The YAMAHA AV-X1800 requires audio infoframe to include speaker-channel
mapping to play >2 channel HDMI audio. In theory that mapping should be
derived from its speaker configurations contained in its ELD. However we
currently cannot get ELD in console before the KMS functionalities are ready.
This is a more or less general issue at least in the near future. As a
workaround, we propose to allow playback of mult-channel audio when ELD
is not available.

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 sound/pci/hda/patch_intelhdmi.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

--- mm.orig/sound/pci/hda/patch_intelhdmi.c
+++ mm/sound/pci/hda/patch_intelhdmi.c
@@ -419,14 +419,18 @@ static int hdmi_setup_channel_allocation
 	/*
 	 * CA defaults to 0 for basic stereo audio
 	 */
-	if (!eld->eld_ver)
-		return 0;
-	if (!eld->spk_alloc)
-		return 0;
 	if (channels <= 2)
 		return 0;
 
 	/*
+	 * HDMI sink's ELD info cannot always be retrieved for now, e.g.
+	 * in console or for audio devices. Assume the highest speakers
+	 * configuration, to _not_ prohibit multi-channel audio playback.
+	 */
+	if (!eld->spk_alloc)
+		eld->spk_alloc = 0xffff;
+
+	/*
 	 * expand ELD's speaker allocation mask
 	 *
 	 * ELD tells the speaker mask in a compact(paired) form,

-- 

  reply	other threads:[~2009-02-11  7:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11  7:22 [PATCH 0/4] Intel HDMI audio fixes Wu Fengguang
2009-02-11  7:22 ` Wu Fengguang [this message]
2009-02-11  7:22 ` [PATCH 2/4] hda - enable HDMI audio pin out at module loading time Wu Fengguang
2009-02-11  7:22 ` [PATCH 3/4] hda - compute checksum in HDMI audio infoframe Wu Fengguang
2009-02-11  7:22 ` [PATCH 4/4] hda - add id for Intel IbexPeak integrated HDMI codec Wu Fengguang
2009-02-11  8:10 ` [PATCH 0/4] Intel HDMI audio fixes Takashi Iwai
2009-02-11  8:20   ` Wu Fengguang
     [not found] ` <20090211223241.GA31322@csy.ca>
2009-02-11 22:42   ` Takashi Iwai
     [not found]     ` <20090211225448.GA32203@csy.ca>
2009-02-11 23:02       ` Takashi Iwai
2009-02-12  4:41         ` Wu Fengguang
     [not found]           ` <20090213172821.GA843@csy.ca>
2009-02-14 10:28             ` Takashi Iwai
2009-02-12  1:25     ` Wu Fengguang
2009-02-12  7:54       ` Takashi Iwai
2009-02-12  7:58         ` Wu Fengguang
2009-02-20 13:05         ` [PATCH] speaker-test.c - add readability comments to speaker channels Wu Fengguang
2009-02-20 17:07           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090211073402.569527628@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=shane-alsa@csy.ca \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.