From: Nanako Shiraishi <nanako3@lavabit.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Tuncer Ayaz <tuncer.ayaz@gmail.com>,
git@vger.kernel.org
Subject: Re: [RFC/PATCH] shortstatus v1
Date: Wed, 11 Feb 2009 08:52:56 +0900 [thread overview]
Message-ID: <20090211085256.6117@nanako3.lavabit.com> (raw)
In-Reply-To: <7vwsbynv0o.fsf@gitster.siamese.dyndns.org>
Quoting Junio C Hamano <gitster@pobox.com>:
> Jeff King <peff@peff.net> writes:
>
>> Some comments:
>>
>> 1. Is the staggered indentation intentional? It looks awful, and the
>> only use I can think of is to separate unstaged from staged
>> changes. But surely there must be a more obvious way of doing so.
>
> Probably not.
>
>> 2. Why do staged changes get a letter marking what happened, but
>> unstaged changes do not?
>
> Bug? FWIW, the original patch from October shows:
>
> M changed
> M M changed-again
> M changed-staged
> D deleted
> D deleted-staged
>
> (where changed-again has both staged changes and further changes in the
> work tree).
>
> The gap between these two are to show the rename similarity index, which
> we could do without.
I have a question. Why do you have the gap for the rename similarity between the two but not between the second status and the filename?
next prev parent reply other threads:[~2009-02-10 23:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 0:51 [RFC/PATCH] shortstatus v1 Tuncer Ayaz
2009-02-10 1:44 ` Junio C Hamano
2009-02-10 3:46 ` Sitaram Chamarty
2009-02-10 10:22 ` Spending time in PS1, was " Johannes Schindelin
2009-02-10 17:31 ` Sitaram Chamarty
2009-02-10 10:11 ` Tuncer Ayaz
2009-02-10 11:03 ` Jeff King
2009-02-10 11:29 ` Michael J Gruber
2009-02-10 11:31 ` Tuncer Ayaz
2009-02-10 11:45 ` Jeff King
2009-02-10 12:36 ` Michael J Gruber
2009-02-10 13:01 ` Jeff King
2009-02-10 15:58 ` Junio C Hamano
2009-02-10 18:10 ` Jeff King
2009-02-10 18:22 ` Jeff King
2009-02-10 19:11 ` Jeff King
2009-02-10 21:21 ` Tuncer Ayaz
2009-02-10 21:36 ` Jeff King
2009-02-10 22:25 ` Junio C Hamano
2009-02-10 22:52 ` Tuncer Ayaz
2009-02-10 22:55 ` Jeff King
2009-02-10 23:05 ` Junio C Hamano
2009-02-12 0:49 ` Jeff King
2009-02-10 23:52 ` Nanako Shiraishi [this message]
2009-02-11 21:24 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2009-02-10 23:58 [RFC] New command: 'git snapshot' Ulrik Sverdrup
2009-02-11 0:08 ` [RFC/PATCH] shortstatus v1 Nanako Shiraishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090211085256.6117@nanako3.lavabit.com \
--to=nanako3@lavabit.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=tuncer.ayaz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.