From: Ingo Molnar <mingo@elte.hu>
To: Alok Kataria <akataria@vmware.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] x86, apic: make generic_apic_probe() generally available
Date: Wed, 11 Feb 2009 11:29:19 +0100 [thread overview]
Message-ID: <20090211102919.GA11000@elte.hu> (raw)
In-Reply-To: <20090211102534.GA9976@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> > I've applied your patch as an interim measure so far, to fix the crash, so
> > please do the cleaner patch ontop of your first patch. Thanks,
>
> I removed it again. generic_apic_probe() is not always available on 32-bit either.
applied the fix below instead.
Ingo
------------------>
>From 160d8dac12932ad6eb4a359b66521e2e3282ea7d Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 11 Feb 2009 11:27:39 +0100
Subject: [PATCH] x86, apic: make generic_apic_probe() generally available
Impact: build fix
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/include/asm/apic.h | 6 ++++++
arch/x86/kernel/setup.c | 2 --
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
index f4835a1..fba49f6 100644
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -33,7 +33,13 @@
} while (0)
+#if defined(CONFIG_X86_LOCAL_APIC) && defined(CONFIG_X86_32)
extern void generic_apic_probe(void);
+#else
+static inline void generic_apic_probe(void)
+{
+}
+#endif
#ifdef CONFIG_X86_LOCAL_APIC
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 150e6d0..8fce6c7 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -936,9 +936,7 @@ void __init setup_arch(char **cmdline_p)
map_vsyscall();
#endif
-#ifdef CONFIG_X86_32
generic_apic_probe();
-#endif
early_quirks();
prev parent reply other threads:[~2009-02-11 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 20:28 [BUGFIX/x86] Fix initialization of wakeup_cpu Alok Kataria
2009-02-10 21:03 ` Yinghai Lu
2009-02-10 22:00 ` Alok Kataria
2009-02-11 0:31 ` Yinghai Lu
2009-02-11 0:45 ` Alok Kataria
2009-02-11 9:46 ` Ingo Molnar
2009-02-11 9:48 ` Ingo Molnar
2009-02-11 10:25 ` Ingo Molnar
2009-02-11 10:29 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090211102919.GA11000@elte.hu \
--to=mingo@elte.hu \
--cc=akataria@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.