From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Wed, 11 Feb 2009 16:48:36 -0500 Subject: [U-Boot] [PATCH 33/42] Blackfin: cm-bf537e: new board port In-Reply-To: <20090211214351.D240F832E893@gemini.denx.de> References: <1234246880-32438-1-git-send-email-vapier@gentoo.org> <1234246880-32438-34-git-send-email-vapier@gentoo.org> <20090211214351.D240F832E893@gemini.denx.de> Message-ID: <200902111648.42603.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 11 February 2009 16:43:51 Wolfgang Denk wrote: > In message Mike Frysinger you wrote: > > +#define SWITCH_BANK do { if (memIndex >= 0x20200000) {\ > > + *pPORTFIO_SET = GPIO_4; \ > > + memIndex -= 0x200000; \ > > + crossed = 1;\ > > + } else { \ > > + *pPORTFIO_CLEAR = GPIO_4; \ > > + } \ > > + asm("ssync;"); } while (0) > > + > > +#define SWITCH_BACK do {if (crossed) {\ > > + *pPORTFIO_CLEAR = GPIO_4; \ > > + memIndex += 0x200000; \ > > + crossed = 0;\ > > + asm("ssync;");\ > > + } } while (0) > > Please use accessor functions instead of pointer accesses (which alslo > will allow you to get rid of the "ssync" stuff here). the ssync would still be required. it's to force the GPIO pins to the proper state, not to make sure some address request has gone out. all the flash drivers in the tinyboard dirs (cm-*) are "throw away" ... they all exist because a common driver does not yet exist to hook CFI compliant flashes up partially with addressing lines and partially with GPIOs. once i get around to implementing that, all of these can be summarily scuttled. sorry, i should have noted this in the summary. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090211/4eeda703/attachment.pgp