From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Darren Hart <dvhltc@us.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH -v4] futex: fix reference leak
Date: Wed, 11 Feb 2009 18:24:28 +0100 [thread overview]
Message-ID: <20090211172428.GA23119@elte.hu> (raw)
In-Reply-To: <1234372210.23438.192.camel@twins>
* Peter Zijlstra <peterz@infradead.org> wrote:
> Subject: futex: fix reference leak
> From: Peter Zijlstra <peterz@infradead.org>
>
> Catalin noticed that (38d47c1b7075: futex: rely on get_user_pages() for
> shared futexes) caused an mm_struct leak.
>
> Some tracing with the function graph tracer quickly pointed out that
> futex_wait() has exit paths with unbalanced reference counts.
>
> This regression was discovered by kmemleak.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Tested-by: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
> Tested-by: Catalin Marinas <catalin.marinas@arm.com>
> Reported-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
> kernel/futex.c | 53 ++++++++++++++++++++++++++++-------------------------
> 1 files changed, 28 insertions(+), 25 deletions(-)
Applied to tip:core/urgent, thanks guys!
Ingo
prev parent reply other threads:[~2009-02-11 17:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 12:18 mm_alloc()'ed structure leak Catalin Marinas
2009-02-09 13:12 ` Catalin Marinas
2009-02-09 14:44 ` Catalin Marinas
2009-02-09 15:12 ` Peter Zijlstra
2009-02-09 16:45 ` Peter Zijlstra
2009-02-09 16:47 ` Peter Zijlstra
2009-02-09 17:28 ` Catalin Marinas
2009-02-09 18:26 ` [PATCH] futex: fix reference leak Peter Zijlstra
2009-02-09 18:53 ` Pallipadi, Venkatesh
2009-02-09 18:57 ` [PATCH -v2] " Peter Zijlstra
2009-02-09 20:49 ` Darren Hart
2009-02-11 12:28 ` Ingo Molnar
2009-02-11 15:36 ` [PATCH -v3] " Peter Zijlstra
2009-02-11 15:49 ` Ingo Molnar
2009-02-11 15:56 ` Peter Zijlstra
2009-02-11 16:26 ` Ingo Molnar
2009-02-11 17:10 ` [PATCH -v4] " Peter Zijlstra
2009-02-11 17:24 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090211172428.GA23119@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=dvhltc@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.