All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	Xen-devel <xen-devel@lists.xensource.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Stable Kernel <stable@kernel.org>,
	Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] x86/cpa: make sure cpa is safe to call in lazy mmu mode
Date: Wed, 11 Feb 2009 18:44:40 +0100	[thread overview]
Message-ID: <20090211174440.GA32633@elte.hu> (raw)
In-Reply-To: <49930BA3.8020305@goop.org>


* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> [ Ingo, this needs to go upstream and -stable. -J ]
>
> commit 2193cee29f66b873b9f8ac2cebb2c7b755ec73a3
> Author: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> Date:   Tue Feb 10 14:15:52 2009 -0800
>
>    x86/cpa: make sure cpa is safe to call in lazy mmu mode
>       Impact: fix race leading to crash under KVM and Xen
>
>    The CPA code may be called while we're in lazy mmu update mode - for
>    example, when using DEBUG_PAGE_ALLOC and doing a slab allocation
>    in an interrupt handler which interrupted a lazy mmu update.  In this
>    case, the in-memory pagetable state may be out of date due to pending
>    queued updates.  We need to flush any pending updates before inspecting
>    the page table.  Similarly, we must explicitly flush any modifications
>    CPA may have made (which comes down to flushing queued operations when
>    flushing the TLB).
>       Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
>    Acked-by: Marcelo Tosatti <mtosatti@redhat.com>

applied to tip:x86/urgent, thanks Jeremy!

	Ingo

      reply	other threads:[~2009-02-11 17:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 17:32 [PATCH] x86/cpa: make sure cpa is safe to call in lazy mmu mode Jeremy Fitzhardinge
2009-02-11 17:44 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090211174440.GA32633@elte.hu \
    --to=mingo@elte.hu \
    --cc=jeremy@goop.org \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=mtosatti@redhat.com \
    --cc=stable@kernel.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.