From: David Brownell <david-b@pacbell.net>
To: Tony Lindgren <tony@atomide.com>
Cc: Kim Kyuwon <chammoru@gmail.com>,
OMAP <linux-omap@vger.kernel.org>,
Manikandan Pillai <mani.pillai@ti.com>
Subject: Re: [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes
Date: Wed, 11 Feb 2009 17:51:13 -0800 [thread overview]
Message-ID: <200902111751.13546.david-b@pacbell.net> (raw)
In-Reply-To: <20090212004500.GG13748@atomide.com>
On Wednesday 11 February 2009, Tony Lindgren wrote:
> > >
> >
> > So the thing is, OMAP34XX_PIN_INPUT doens't mean input-only, but
> > input-and-output. And OMAP34XX_PIN_OUTPUT doen't mean output, but output-only.
> > Names of macros are really confusing me. Shouldn't we change names of these
> > macros first? For example,
> > OMAP34XX_PIN_INPUT -> OMAP34XX_PIN_INPUT_EN
> > OMAP34XX_PIN_OUTPUT -> OMAP34XX_PIN_OUTPUT_ONLY
>
> I like this idea to cut down on confusion.
Makes sense to me. Though I suggest merging this first,
and then changing everything in the tree ... instead of
changing everything first, and then redoing this patch. :)
next prev parent reply other threads:[~2009-02-12 1:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 4:55 [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes David Brownell
2009-02-09 12:24 ` Kim Kyuwon
2009-02-12 0:45 ` Tony Lindgren
2009-02-12 1:51 ` David Brownell [this message]
2009-02-27 22:46 ` Tony Lindgren
2009-02-27 22:48 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902111751.13546.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=chammoru@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=mani.pillai@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.