From: "Shawn O. Pearce" <spearce@spearce.org>
To: Yann Simon <yann.simon.fr@gmail.com>
Cc: Robin Rosenberg <robin.rosenberg.lists@dewire.com>,
git <git@vger.kernel.org>
Subject: Re: [PATCH JGIT] In the commit dialog, deal with Signed-off-by not on the last line (WAS: [PATCH JGIT] Deal with the signed-off in the commit text dialog)
Date: Wed, 11 Feb 2009 11:40:58 -0800 [thread overview]
Message-ID: <20090211194058.GV30949@spearce.org> (raw)
In-Reply-To: <499304A2.1060908@gmail.com>
Yann Simon <yann.simon.fr@gmail.com> wrote:
>
> This patch should correct this assumption.
Maybe, but it can't be applied...
> + String neuSignOff = getSignedOff(neuCommitter);
> +
> commitText.setText(replaceSignOff(commitText.getText(), oldSignOff,
> neuSignOff));
> + oldCommitter = neuCommitter;
That's whitespace corruption.
--
Shawn.
prev parent reply other threads:[~2009-02-11 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 12:55 [PATCH JGIT] Deal with the signed-off in the commit text dialog Yann Simon
2009-02-11 0:16 ` Robin Rosenberg
2009-02-11 17:02 ` [PATCH JGIT] In the commit dialog, deal with Signed-off-by not on the last line (WAS: [PATCH JGIT] Deal with the signed-off in the commit text dialog) Yann Simon
2009-02-11 19:40 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090211194058.GV30949@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg.lists@dewire.com \
--cc=yann.simon.fr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.