On (26/01/09 08:24), Phil Blundell wrote: > On Sun, 2009-01-25 at 23:49 -0800, Khem Raj wrote: > > * These funtions are provided by C libraries like uclibc > > Declaring them static here causes static not static declaration > > issues reported by gcc. > > [...] > > + #ifdef __GLIBC__ > > +-static size_t strlcpy(char *dst, const char *src, size_t size) > > ++size_t strlcpy(char *dst, const char *src, size_t size) > > + { > > Wouldn't it be better to change that "#ifdef __GLIBC__" to something > more appropriate? With your change it looks like you will still get > useless copies of these functions in the resulting binaries. here is a different patch.