All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: Gleb Natapov <gleb@redhat.com>
Cc: avi@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] Don't unregister unassigned PCI BAR
Date: Wed, 11 Feb 2009 17:35:35 -0800	[thread overview]
Message-ID: <20090212013535.GS27684@sequoia.sous-sol.org> (raw)
In-Reply-To: <20090203115819.GB30234@redhat.com>

* Gleb Natapov (gleb@redhat.com) wrote:
> --- a/qemu/hw/pci.c
> +++ b/qemu/hw/pci.c
> @@ -213,7 +213,7 @@ static void pci_unregister_io_regions(PCIDevice *pci_dev)
>  
>      for(i = 0; i < PCI_NUM_REGIONS; i++) {
>          r = &pci_dev->io_regions[i];
> -        if (!r->size)
> +        if (!r->size || r->addr == -1)
>              continue;

Without this patch the error path for device assignment will segfault
(trying to unregister addr -1).  Please consider for maint/2.6.29.

thanks,
-chris

      parent reply	other threads:[~2009-02-12  1:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03 11:58 [PATCH] Don't unregister unassigned PCI BAR Gleb Natapov
2009-02-03 11:26 ` Marcelo Tosatti
2009-02-03 12:25 ` Avi Kivity
2009-02-12  1:35 ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090212013535.GS27684@sequoia.sous-sol.org \
    --to=chrisw@sous-sol.org \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.