From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] OCFS2: add IO error check in ocfs2_get_sector() -v2
Date: Thu, 12 Feb 2009 14:15:10 -0800 [thread overview]
Message-ID: <20090212221510.GA12965@mail.oracle.com> (raw)
In-Reply-To: <49947EB2.5090503@oracle.com>
On Thu, Feb 12, 2009 at 11:55:30AM -0800, Sunil Mushran wrote:
> I am looking at the brelse() in ocfs2_fill_super().
Oh, right. Then Wengang's patch should null out *bh when
brelsing it. No point in passing a garbage bh all the way up.
Joel
>
> Joel Becker wrote:
> > On Thu, Feb 12, 2009 at 11:23:42AM -0800, Sunil Mushran wrote:
> >
> >> The matching brelse() is in ocfs2_fill_super(). So you shouldn't
> >> need it. Cross check though please.
> >>
> >
> > No, if we get an error from ocfs2_get_sector() we return without
> > brelse(). So the patch is correct.
> >
> > Joel
> >
> >
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
--
"The one important thing i have learned over the years is the
difference between taking one's work seriously and taking one's self
seriously. The first is imperative and the second is disastrous."
-Margot Fonteyn
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2009-02-12 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 7:47 [Ocfs2-devel] [PATCH 1/1] OCFS2: add IO error check in ocfs2_get_sector() -v2 wengang wang
2009-02-12 19:23 ` Sunil Mushran
2009-02-12 19:46 ` Joel Becker
2009-02-12 19:55 ` Sunil Mushran
2009-02-12 22:15 ` Joel Becker [this message]
2009-02-12 19:45 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090212221510.GA12965@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.