All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: bugme-daemon@bugzilla.kernel.org
Cc: linux-ext4@vger.kernel.org
Subject: Re: [Bug 12579] ext4 filesystem hang
Date: Sat, 14 Feb 2009 13:36:40 +0530	[thread overview]
Message-ID: <20090214080640.GA22585@skywalker> (raw)
In-Reply-To: <20090213220606.AE8FC11D109@picon.linux-foundation.org>

On Fri, Feb 13, 2009 at 02:06:06PM -0800, bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=12579
> 
> 
> 
> 
> 
> ------- Comment #8 from sandeen@redhat.com  2009-02-13 14:06 -------
> Created an attachment (id=20238)
>  --> (http://bugzilla.kernel.org/attachment.cgi?id=20238&action=view)
> Tested patch
> 
> Patch from Aneesh, un-whitespace-mangled.
> 
> Ted, can you push this out?  Works great.  :)  We might want to ask the other
> reporter of something similar (next-20090206: deadlock on ext4) to test it too.
>  I'll ping him.
> 

I think this small changes is also needed.

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index f743524..c80e038 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2495,7 +2495,10 @@ static int ext4_da_writepages(struct address_space *mapping,
 		wbc->range_end  = LLONG_MAX;
 		wbc->range_cyclic = 0;
 		range_cyclic = 1;
-		cycled = 0;
+		if (index == 0)
+			cycled = 1;
+		else
+			cycled = 0;
 	} else
 		index = wbc->range_start >> PAGE_CACHE_SHIFT;
 

  parent reply	other threads:[~2009-02-14  8:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-30  5:03 [Bug 12579] New: ext4 filesystem hang bugme-daemon
2009-02-12 15:24 ` [Bug 12579] " bugme-daemon
2009-02-12 16:36   ` Aneesh Kumar K.V
2009-02-12 17:49     ` Theodore Tso
2009-02-12 16:37 ` bugme-daemon
2009-02-12 16:44 ` bugme-daemon
2009-02-12 18:48 ` bugme-daemon
2009-02-12 18:55 ` bugme-daemon
2009-02-13  0:42 ` bugme-daemon
2009-02-13 11:49   ` Aneesh Kumar K.V
2009-02-13 11:50 ` bugme-daemon
2009-02-13 22:06 ` bugme-daemon
2009-02-14  1:50   ` Theodore Tso
2009-02-14  8:40     ` Aneesh Kumar K.V
2009-02-14  9:41       ` Aneesh Kumar K.V
2009-02-14  8:06   ` Aneesh Kumar K.V [this message]
2009-02-13 22:22 ` bugme-daemon
2009-02-14  2:07 ` bugme-daemon
2009-02-14  3:52 ` bugme-daemon
2009-02-14  8:07 ` bugme-daemon
2009-02-14  8:40 ` bugme-daemon
2009-02-14  9:42 ` bugme-daemon
2009-02-20  2:31 ` bugme-daemon
2009-02-21 17:35 ` bugme-daemon
2010-02-27 18:29 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090214080640.GA22585@skywalker \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.