From: Jean Delvare <khali@linux-fr.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Frank Seidel <fseidel@suse.de>,
linux kernel <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, rlove@rlove.org, protasnb@gmail.com,
Michael Ruoss <miruoss@student.ethz.ch>,
Tim Gardner <tim.gardner@canonical.com>,
Frank Seidel <frank@f-seidel.de>
Subject: Re: [PATCH] hwmon/hdaps: Fix bug 7154 inversion of separate axis
Date: Sun, 15 Feb 2009 14:34:33 +0100 [thread overview]
Message-ID: <20090215143433.68241a34@hyperion.delvare> (raw)
In-Reply-To: <20090214142346.ZZRA012@mailhub.coreip.homeip.net>
On Sat, 14 Feb 2009 14:25:56 -0800, Dmitry Torokhov wrote:
> On Fri, Feb 13, 2009 at 01:38:01PM +0100, Frank Seidel wrote:
> > -module_param_named(invert, hdaps_invert, bool, 0);
> > -MODULE_PARM_DESC(invert, "invert data along each axis");
> > +module_param_named(invert, hdaps_invert, int, 0);
> > +MODULE_PARM_DESC(invert, "invert data along each axis. 1 invert x-axis, "
> > + "2 invert y-axis, 3 invert both axes.");
> >
>
> Why don't you make these 0644? I don't see why they can't be changed
> "on fly".
hdaps_invert can already be read and written via a sysfs attribute. We
really don't need 2 ways to do it, so either the sysfs file or the
module parameter should be dropped.
--
Jean Delvare
next prev parent reply other threads:[~2009-02-15 13:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 12:38 [PATCH] hwmon/hdaps: Fix bug 7154 inversion of separate axis Frank Seidel
2009-02-14 22:25 ` Dmitry Torokhov
2009-02-15 13:34 ` Jean Delvare [this message]
2009-02-15 0:32 ` Shem Multinymous
2009-02-15 9:27 ` Jean Delvare
2009-02-15 13:41 ` Matthew Garrett
2009-02-15 15:23 ` Jean Delvare
2009-02-15 15:28 ` Matthew Garrett
2009-02-15 9:36 ` Jean Delvare
2009-02-15 12:16 ` [PATCHv2] " Frank Seidel
2009-02-15 13:01 ` [PATCHv3] " Frank Seidel
2009-02-15 14:37 ` Jean Delvare
2009-02-19 12:43 ` [PATCH] hwmon/hdaps: Fix bug 7154 adaption for Thinkpad X41 Frank Seidel
2009-02-19 17:16 ` Jean Delvare
2009-02-19 12:44 ` [PATCH] hwmon/hdaps: remove redundant sysfs invert Frank Seidel
2009-02-19 17:27 ` Jean Delvare
2009-02-19 20:00 ` Frank Seidel
2009-02-19 20:34 ` Jean Delvare
2009-02-20 8:35 ` Frank Seidel
2009-02-15 13:02 ` [PATCHv2] hwmon/hdaps: Fix bug 7154 inversion of separate axis Frank Seidel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090215143433.68241a34@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=frank@f-seidel.de \
--cc=fseidel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=miruoss@student.ethz.ch \
--cc=protasnb@gmail.com \
--cc=rlove@rlove.org \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.