From: Jamie Lokier <jamie@shareable.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Revert block-qcow2.c to kvm-72 version due to corruption reports
Date: Sun, 15 Feb 2009 15:42:07 +0000 [thread overview]
Message-ID: <20090215154207.GA24821@shareable.org> (raw)
In-Reply-To: <f085eb030902142009h343b72b0h8198bea6b8450d69@mail.gmail.com>
Anthony Liguori wrote:
> On Sat, Feb 14, 2009 at 8:01 PM, Jamie Lokier <jamie@shareable.org> wrote:
> > Have done, did you read the other thread?
>
> Yes, but your patch confused me (which is admittedly not hard).
>
> >> It's QEMU SVN delta 5005-5006, copied below.
>
> So why such an aggressive revert? Why not just revert the problematic
> changesets?
Because most of the following changes look too dependent on it.
I did keep a couple of changes which are trivially independent since
that one - default to "cache=writeback" and eliminating #define
offsetof.
You have a point that QEMU SVN deltas up to 5005 don't need to be
reverted. Reason for that: I simply don't have time to trim the patch
down to its bare essentials quickly, and being a corruption bug, it
should be dealt with quickly. This one seems to work; feel free to
improve it by reverting less, or waiting a long time for me to do so :-)
-- Jamie
next prev parent reply other threads:[~2009-02-15 15:42 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 20:48 [Qemu-devel] Cutting a new QEMU release Anthony Liguori
2009-02-03 20:58 ` Glauber Costa
2009-02-03 21:35 ` Laurent Desnogues
2009-02-03 21:50 ` Anthony Liguori
2009-02-03 22:05 ` Laurent Desnogues
2009-02-03 22:47 ` Anthony Liguori
2009-02-03 23:48 ` Glauber Costa
2009-02-04 13:09 ` Ulrich Hecht
2009-02-04 0:31 ` David Turner
2009-02-04 5:08 ` C.W. Betts
2009-02-04 5:08 ` C.W. Betts
2009-02-03 21:48 ` Rick Vernam
2009-02-03 22:07 ` Daniel P. Berrange
2009-02-04 14:50 ` Aurelien Jarno
2009-02-04 15:23 ` Tristan Gingold
2009-02-04 15:43 ` Lennart Sorensen
2009-02-04 16:01 ` Tristan Gingold
2009-02-04 18:17 ` [Qemu-devel] " Consul
2009-02-04 17:39 ` [Qemu-devel] " Blue Swirl
2009-02-04 17:50 ` Jonathan Kalbfeld
2009-02-04 20:07 ` Blue Swirl
2009-02-07 14:15 ` Stuart Brady
2009-02-04 15:58 ` Glauber Costa
2009-02-07 15:29 ` Shin-ichiro KAWASAKI
2009-02-11 21:49 ` Rob Landley
2009-02-12 14:44 ` Shin-ichiro KAWASAKI
2009-02-12 21:08 ` Rob Landley
2009-02-12 21:44 ` Rob Landley
2009-02-09 12:43 ` Mark McLoughlin
2009-02-09 21:36 ` Anthony Liguori
2009-02-10 0:47 ` Rob Landley
2009-02-10 7:22 ` M. Warner Losh
2009-02-13 8:40 ` Riku Voipio
2009-02-13 9:59 ` Stefano Stabellini
2009-02-13 16:30 ` Jamie Lokier
2009-02-13 17:00 ` Anthony Liguori
2009-02-13 19:04 ` [Qemu-devel] [PATCH] Revert block-qcow2.c to kvm-72 version due to corruption reports Jamie Lokier
2009-02-14 22:23 ` Dor Laor
2009-02-15 2:20 ` Jamie Lokier
2009-02-14 23:13 ` Anthony Liguori
2009-02-15 2:01 ` Jamie Lokier
2009-02-15 4:09 ` Anthony Liguori
2009-02-15 15:42 ` Jamie Lokier [this message]
2009-02-15 18:19 ` Anthony Liguori
2009-02-15 18:34 ` Johannes Schindelin
2009-02-16 1:01 ` Anthony Liguori
2009-02-17 0:52 ` Jamie Lokier
2009-02-17 2:55 ` Anthony Liguori
2009-02-16 1:19 ` Anthony Liguori
2009-02-17 1:01 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090215154207.GA24821@shareable.org \
--to=jamie@shareable.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.