All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Dévai Tamás" <devait@mailbox.sk>
Subject: Re: [PATCH] git-svn: Fix for rewriteRoot URL containing username.
Date: Sun, 15 Feb 2009 16:55:25 -0800	[thread overview]
Message-ID: <20090216005525.GA20625@untitled> (raw)
In-Reply-To: <1234394042-11577-1-git-send-email-devait@mailbox.sk>

Dévai Tamás <devait@mailbox.sk> wrote:
> If the new svn root URL given with the svn-remote.<repo>.rewriteRoot config option
> (or by the --rewrite-root option to 'git svn init') contains a username
> (such as 'svn+ssh://username@example.com/repo'), find_by_url() cannot find
> the repository URL, because the URL contained in the commit message does have
> the username removed.
> 
> Signed-off-by: Dévai Tamás <devait@mailbox.sk>

Thanks Dévai,

Acked-by: Eric Wong <normalperson@yhbt.net>

> ---
>  git-svn.perl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index 001a1d8..83cb36f 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1693,6 +1693,7 @@ sub find_by_url { # repos_root and, path are optional
>  			my $prefix = '';
>  			if ($rwr) {
>  				$z = $rwr;
> +				remove_username($z);
>  			} elsif (defined $svm) {
>  				$z = $svm->{source};
>  				$prefix = $svm->{replace};
> -- 
> 1.6.1.2

      reply	other threads:[~2009-02-16  0:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 23:14 [PATCH] git-svn: Fix for rewriteRoot URL containing username Dévai Tamás
2009-02-16  0:55 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090216005525.GA20625@untitled \
    --to=normalperson@yhbt.net \
    --cc=devait@mailbox.sk \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.