From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Wed, 18 Feb 2009 01:27:01 +0000 Subject: Re: [PATCH 14/43] drivers/net/bonding: fix sparse warnings: Message-Id: <20090217.172701.10220214.davem@davemloft.net> List-Id: References: <20090214210940.23489.95001.stgit@vmbox.hanneseder.net> <20090214211525.23489.61644.stgit@vmbox.hanneseder.net> In-Reply-To: <20090214211525.23489.61644.stgit@vmbox.hanneseder.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: hannes@hanneseder.net Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Hannes Eder Date: Sat, 14 Feb 2009 22:15:33 +0100 > Impact: Attribute functions with __acquires(...) and/or __releases(...). > > Fix this sparse warnings: > drivers/net/bonding/bond_alb.c:1675:9: warning: context imbalance in 'bond_alb_handle_active_change' - unexpected unlock > drivers/net/bonding/bond_alb.c:1742:9: warning: context imbalance in 'bond_alb_set_mac_address' - unexpected unlock > drivers/net/bonding/bond_main.c:1025:17: warning: context imbalance in 'bond_do_fail_over_mac' - unexpected unlock > drivers/net/bonding/bond_main.c:3195:13: warning: context imbalance in 'bond_info_seq_start' - wrong count at exit > drivers/net/bonding/bond_main.c:3234:13: warning: context imbalance in 'bond_info_seq_stop' - unexpected unlock > > Signed-off-by: Hannes Eder Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756738AbZBRB2w (ORCPT ); Tue, 17 Feb 2009 20:28:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756051AbZBRB1S (ORCPT ); Tue, 17 Feb 2009 20:27:18 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:54463 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756056AbZBRB1R (ORCPT ); Tue, 17 Feb 2009 20:27:17 -0500 Date: Tue, 17 Feb 2009 17:27:01 -0800 (PST) Message-Id: <20090217.172701.10220214.davem@davemloft.net> To: hannes@hanneseder.net Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/43] drivers/net/bonding: fix sparse warnings: context imbalance From: David Miller In-Reply-To: <20090214211525.23489.61644.stgit@vmbox.hanneseder.net> References: <20090214210940.23489.95001.stgit@vmbox.hanneseder.net> <20090214211525.23489.61644.stgit@vmbox.hanneseder.net> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hannes Eder Date: Sat, 14 Feb 2009 22:15:33 +0100 > Impact: Attribute functions with __acquires(...) and/or __releases(...). > > Fix this sparse warnings: > drivers/net/bonding/bond_alb.c:1675:9: warning: context imbalance in 'bond_alb_handle_active_change' - unexpected unlock > drivers/net/bonding/bond_alb.c:1742:9: warning: context imbalance in 'bond_alb_set_mac_address' - unexpected unlock > drivers/net/bonding/bond_main.c:1025:17: warning: context imbalance in 'bond_do_fail_over_mac' - unexpected unlock > drivers/net/bonding/bond_main.c:3195:13: warning: context imbalance in 'bond_info_seq_start' - wrong count at exit > drivers/net/bonding/bond_main.c:3234:13: warning: context imbalance in 'bond_info_seq_stop' - unexpected unlock > > Signed-off-by: Hannes Eder Applied.