From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Wed, 18 Feb 2009 03:35:46 +0000 Subject: Re: [PATCH 40/43] drivers/net/wireless/ath9k: fix sparse warnings: Message-Id: <20090217.193546.115478499.davem@davemloft.net> List-Id: References: <20090214210940.23489.95001.stgit@vmbox.hanneseder.net> <20090214214935.24377.69824.stgit@vmbox.hanneseder.net> In-Reply-To: <20090214214935.24377.69824.stgit@vmbox.hanneseder.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: hannes@hanneseder.net Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Hannes Eder Date: Sat, 14 Feb 2009 22:49:48 +0100 > Impact: Make symbols static. > > Fix this sparse warnings: > drivers/net/wireless/ath9k/eeprom.c:1343:5: warning: symbol 'ath9k_hw_4k_get_spur_channel' was not declared. Should it be static? > drivers/net/wireless/ath9k/eeprom.c:1372:19: warning: symbol 'eep_4k_ops' was not declared. Should it be static? > drivers/net/wireless/ath9k/eeprom.c:2649:5: warning: symbol 'ath9k_hw_def_get_spur_channel' was not declared. Should it be static? > drivers/net/wireless/ath9k/eeprom.c:2678:19: warning: symbol 'eep_def_ops' was not declared. Should it be static? > > Signed-off-by: Hannes Eder Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755708AbZBRDjF (ORCPT ); Tue, 17 Feb 2009 22:39:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754862AbZBRDgH (ORCPT ); Tue, 17 Feb 2009 22:36:07 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:59020 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754850AbZBRDgC (ORCPT ); Tue, 17 Feb 2009 22:36:02 -0500 Date: Tue, 17 Feb 2009 19:35:46 -0800 (PST) Message-Id: <20090217.193546.115478499.davem@davemloft.net> To: hannes@hanneseder.net Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 40/43] drivers/net/wireless/ath9k: fix sparse warnings: Should it be static? From: David Miller In-Reply-To: <20090214214935.24377.69824.stgit@vmbox.hanneseder.net> References: <20090214210940.23489.95001.stgit@vmbox.hanneseder.net> <20090214214935.24377.69824.stgit@vmbox.hanneseder.net> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hannes Eder Date: Sat, 14 Feb 2009 22:49:48 +0100 > Impact: Make symbols static. > > Fix this sparse warnings: > drivers/net/wireless/ath9k/eeprom.c:1343:5: warning: symbol 'ath9k_hw_4k_get_spur_channel' was not declared. Should it be static? > drivers/net/wireless/ath9k/eeprom.c:1372:19: warning: symbol 'eep_4k_ops' was not declared. Should it be static? > drivers/net/wireless/ath9k/eeprom.c:2649:5: warning: symbol 'ath9k_hw_def_get_spur_channel' was not declared. Should it be static? > drivers/net/wireless/ath9k/eeprom.c:2678:19: warning: symbol 'eep_def_ops' was not declared. Should it be static? > > Signed-off-by: Hannes Eder Applied.