Re: [PATCH] ext4: Fix to read empty directory blocks correctly in 64k blocksize filesystems

[Theodore Tso <tytso@mit.edu>]

On Mon, Feb 16, 2009 at 04:32:56PM -0700, Andreas Dilger wrote:
> There are probably a dozen other places in the ext* code that expect
> blocksize <= 65536, so I don't think this new encoding is really helping
> us at all.  We are already restricted to 2^32-1 inodes due to the dirent
> format and I expect we will have changed the dirent format by that time
> anyways.

I can only find one other place, actually, which would be the extended
attribute code --- e_value_offs is a 16 bit offset (although we could
steal bits form e_value block if necessary).

> I'd rather keep this change as simple as possible (i.e. the original
> 65535 or 0 values, preferring 65535).

For 64k block sizes, I've kept this, although I preferred 0 since it's
a cleaner change if we want to allow bigger blocksize alternative.  I
don't think 65535 is any worse than 0 in terms of detecting directory
corruption.

					- Ted