Re: [PATCH 1/3] sched: code cleanup - sd_power_saving_flags(), sd_balance_for_mc/package_power()

[Gautham R Shenoy <ego@in.ibm.com>]

On Mon, Feb 16, 2009 at 06:43:01PM +0100, Peter Zijlstra wrote:
> On Mon, 2009-02-16 at 22:21 +0530, Gautham R Shenoy wrote:
> 
> > +enum sched_domain_level {
> > +	SD_LV_NONE = 0,
> > +	SD_LV_SIBLING,
> > +	SD_LV_MC,
> > +	SD_LV_CPU,
> > +	SD_LV_NODE,
> > +	SD_LV_ALLNODES,
> > +	SD_LV_MAX
> > +};
> 
> 
> Better names would be:
> 
>  LV_THREAD
>  LV_CORE
>  LV_PACKAGE
>  LV_NODE
> 
> But I realize that renaming these is going to be painful, however could
> we at least provide proper comments with these to describe them. I
> always get confused.

Will do the comments for now.

While on the topic, it might also be a good thing to discuss/consider renaming.
I am for it, since these newer names are much more intuitive when compared to
the existing ones.

>

-- 
Thanks and Regards
gautham