All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nye Liu <nyet@mrv.com>
To: linux-kernel@vger.kernel.org, nyet@nyet.org
Subject: [PATCH] modules: hid id->bus needs TO_NATIVE() in scripts/mod/file2alias.c
Date: Tue, 17 Feb 2009 00:45:27 -0800	[thread overview]
Message-ID: <20090217084523.GA3623@mrv.com> (raw)

From: Nye Liu <nyet@mrv.com>

When building a module alias, the bus identifier must be converted to
native endianness. The hid bus id entries were not being properly
swapped in little endian systems.

For example:

    # modinfo hid_dell
    filename:
    /lib/modules/2.6.28-1-amd64/kernel/drivers/hid/hid-dell.ko
    license: GPL
    alias: hid:b0300v000013BAp00000017
    alias: hid:b0300v0000413Cp00002105
    alias: hid:b0300v0000413Cp00002005
    depends: hid,usbhid

b0300 should read b0003

Signed-off-by: Nye Liu <nyet@mrv.com>

diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index 491b8b1..4eea60b 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -210,6 +210,7 @@ static void do_usb_table(void *symval, unsigned long size,
 static int do_hid_entry(const char *filename,
                             struct hid_device_id *id, char *alias)
 {
+       id->bus = TO_NATIVE(id->bus);
        id->vendor = TO_NATIVE(id->vendor);
        id->product = TO_NATIVE(id->product);
 

-- 
Nye Liu
nliu@mrv.com
(818) 772-6235x248
(818) 772-0576 fax

"Who would be stupid enough to quote a fictitious character?"
	-- Don Quixote

                 reply	other threads:[~2009-02-17  8:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090217084523.GA3623@mrv.com \
    --to=nyet@mrv.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nyet@nyet.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.