All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Karl Hiramoto <karl@hiramoto.org>,
	netdev@vger.kernel.org, netfilter@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: problem with IPoA (CLIP),  NAT, and VLANS
Date: Tue, 17 Feb 2009 09:52:00 +0000	[thread overview]
Message-ID: <20090217095200.GA5538@ff.dom.local> (raw)
In-Reply-To: <499A7D7D.1090607@trash.net>

On Tue, Feb 17, 2009 at 10:03:57AM +0100, Patrick McHardy wrote:
...
> The first patch looks fine. As for the second one, I would like
> to understand why we're seing these packets. The VLAN driver uses
> the original headroom plus the space it needs itself, which suggests
> that the underlying driver specifies an incorrect headroom.
> The driver doesn't appear to be part of the mainline kernel though.

On the other hand, if Karl added his patch it seems this change of
NET_SKB_PAD isn't enough, and if omitting skb_cow_head() works, then
the headroom isn't the main problem?

Jarek P.

  parent reply	other threads:[~2009-02-17  9:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 13:28 problem with IPoA (CLIP), NAT, and VLANS Karl Hiramoto
2009-02-16 15:02 ` Karl Hiramoto
2009-02-16 23:20   ` Jarek Poplawski
2009-02-17  9:03     ` Patrick McHardy
2009-02-17  9:32       ` [PATCH] " Jarek Poplawski
2009-02-17  9:39       ` [PATCH v2] " Jarek Poplawski
2009-02-17 11:05         ` Karl Hiramoto
2009-02-17 11:53           ` Jarek Poplawski
2009-02-19  7:31         ` David Miller
2009-02-17  9:52       ` Jarek Poplawski [this message]
2009-02-17 11:49     ` Karl Hiramoto
2009-02-17 12:20       ` Jarek Poplawski
2009-02-17 12:53         ` Karl Hiramoto
2009-02-17 13:37           ` Jarek Poplawski
2009-02-17 23:12           ` Jarek Poplawski
2009-02-18 17:47             ` Karl Hiramoto
2009-02-18 21:05               ` Jarek Poplawski
2009-02-19  7:30                 ` Jarek Poplawski
2009-02-17 12:28       ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090217095200.GA5538@ff.dom.local \
    --to=jarkao2@gmail.com \
    --cc=kaber@trash.net \
    --cc=karl@hiramoto.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.