From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752972AbZBQLJD (ORCPT ); Tue, 17 Feb 2009 06:09:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751110AbZBQLIy (ORCPT ); Tue, 17 Feb 2009 06:08:54 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:52610 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbZBQLIx (ORCPT ); Tue, 17 Feb 2009 06:08:53 -0500 Date: Tue, 17 Feb 2009 06:08:42 -0500 From: Christoph Hellwig To: Ivan Kokshaysky Cc: Andrew Morton , Richard Henderson , Al Viro , linux-kernel@vger.kernel.org Subject: Re: [PATCH] alpha: binfmt_aout fix Message-ID: <20090217110842.GA22272@infradead.org> References: <20090217104956.GC25856@jurassic.park.msu.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090217104956.GC25856@jurassic.park.msu.ru> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 17, 2009 at 01:49:56PM +0300, Ivan Kokshaysky wrote: > This fixes the problem introduced by commit 3bfacef412 (get rid of > special-casing the /sbin/loader on alpha): osf/1 ecoff binary > segfaults when binfmt_aout built as module. That happens because > aout binary handler gets on the top of the binfmt list due to late > registration, and kernel attempts to execute the binary without > preparation work that must be done by binfmt_loader. I think the proper fix for this is to make sure newly registered binfmts are added to the tail of the list, not the front.