From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mike Rapoport <mike@compulab.co.il>
Cc: lrg@slimlogic.co.uk, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: wm97xx: add BTN_TOUCH event to wm97xx to use it with Android
Date: Tue, 17 Feb 2009 13:30:28 +0000 [thread overview]
Message-ID: <20090217133028.GD16303@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <499AA29B.8090803@compulab.co.il>
On Tue, Feb 17, 2009 at 01:42:19PM +0200, Mike Rapoport wrote:
> The difficulty here is to find out when BTN_TOUCH should be generated and what
> should be its value. As far as I can see from different drivers, there's no
> one-to-one correspondence between ABS_PRESSURE and BTN_TOUCH. For instance,
> drivers/input/mouse/synaptics.c has
As a default it should be fine to check for zero/non-zero. Anything
that wants to override the behaviour could supply their own BTN_TOUCH.
Another option would be to change Android user space to support pressure
only touchscreens.
Like I say, I'm fine with the patch itself so it's got my ack - it just
feels like it fixes the problem at the wrong level. From that PoV
consider it to have
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2009-02-17 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 9:43 [PATCH] Input: wm97xx: add BTN_TOUCH event to wm97xx to use it with Android Mike Rapoport
2009-02-17 10:02 ` Mark Brown
2009-02-17 11:42 ` Mike Rapoport
2009-02-17 13:30 ` Mark Brown [this message]
2009-02-18 7:29 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217133028.GD16303@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-input@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.