All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Ralf Hildebrandt <Ralf.Hildebrandt@charite.de>,
	stable@kernel.org, linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Federico Cuello <fedux@lugmen.org.ar>,
	Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Subject: Re: sync-Regression in 2.6.28.2?
Date: Tue, 17 Feb 2009 15:17:23 +1100	[thread overview]
Message-ID: <200902171517.23980.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <20090215134235.GB15398@charite.de>

On Monday 16 February 2009 00:42:35 Ralf Hildebrandt wrote:
> * Ralf Hildebrandt <Ralf.Hildebrandt@charite.de>:
> > > This patch seems good to me. If you would care to add a changelog and
> > > Signed-off-by: line, then we could get it merged?
> > >
> > > I am not too sure about this bug. I have reproduced a strange hang with
> > > ext4 (which does include sys_sync and write_cache_pages traces), and
> > > also turned up a lockdep report. Also, we haven't seen any reports of
> > > this problem on other filesystems. So it could be an ext4 bug.
> > >
> > > Your traces also have lots of tasks hung waiting for page lock. It is
> > > possible that wakeups get lost, which is fixed by this commit in
> > > mainline
> > > 777c6c5f1f6e757ae49ecca2ed72d6b1f523c007
> > >
> > > Which might also be your bug.
> > >
> > >
> > > Any chance you can test this patch (as well as the existing patches
> > > you are using to fix write_cache_pages?).
> >
> > I could test 2.6.28.4
>
> Still there in 2.6.28.5 :(

I believe it is basically a deadlock in ext4 due to the cyclic writeback
change.

http://git.kernel.org/?p=linux/kernel/git/tytso/ext4.git;a=commitdiff;h=2acf2c261b823d9d9ed954f348b97620297a36b5

ext4 guys, is this correct? Is there a minimal fix that can be made for
.stable kernels?

  reply	other threads:[~2009-02-17  4:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-27  9:35 sync-Regression in 2.6.28.2? Ralf Hildebrandt
2009-01-27 21:09 ` Federico Cuello
2009-02-03  1:09   ` Nick Piggin
2009-02-03 19:51     ` Federico Cuello
2009-02-04  6:17       ` Nick Piggin
2009-02-04 17:31         ` Federico Cuello
2009-02-05  3:25           ` Nick Piggin
2009-02-05 11:54             ` Federico Cuello
2009-02-09 13:45               ` Nick Piggin
2009-02-09 13:49                 ` Ralf Hildebrandt
2009-02-15 13:42                   ` Ralf Hildebrandt
2009-02-17  4:17                     ` Nick Piggin [this message]
2009-02-17 15:15                       ` Ralf Hildebrandt
2009-02-05 10:19           ` Ralf Hildebrandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902171517.23980.nickpiggin@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=Ralf.Hildebrandt@charite.de \
    --cc=fedux@lugmen.org.ar \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.