All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Frank Li <lznuaa@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [ANNOUNCE] Gerrit Code Review 2.0.3
Date: Tue, 17 Feb 2009 07:18:38 -0800	[thread overview]
Message-ID: <20090217151838.GI18525@spearce.org> (raw)
In-Reply-To: <1976ea660902162311q12e11ec5g7a43ab637186985e@mail.gmail.com>

Frank Li <lznuaa@gmail.com> wrote:
> when I click http://review.source.android.com/open , A Gerrit file
> download by IE

Likely it is this open bug:

  http://jira.source.android.com/jira/browse/GERRIT-62

Gerrit is known to not work in Internet Explorer.  As an open source
developer, my primary desktop system runs Linux.  My portable laptops
all run Mac OS X, because its shiny.  I have no system capable of
running Internet Explorer, nor do I desire to send dollars towards
Redmond in order to obtain an OS license in order to do so.

Something is busted in the IE AJAX code used by Gerrit Code Review.
I'm guessing that instead of making the data available to the AJAX
callback, IE wants to save it as a file on disk.  No clue why.
And due to the lack of IE, I am unable to debug the problem myself.
I am waiting for someone who really cares about using IE to debug
it and contribute the patch back.

FWIW, there are open source browsers available even for Microsoft
Windows.  Firefox and Chrome come to mind...  both work, as their
underlying engines are ported to more OSes and are easier to test.
Firefox is currently better tested however.
 
> 2009/2/17 Shawn O. Pearce <spearce@spearce.org>:
> > Gerrit is a web based code review system, facilitating online code
> > reviews for projects using the Git version control system.
> > 
> >  Live Demo:  http://review.source.android.com/open

-- 
Shawn.

  reply	other threads:[~2009-02-17 15:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17  1:12 [ANNOUNCE] Gerrit Code Review 2.0.3 Shawn O. Pearce
2009-02-17  7:11 ` Frank Li
2009-02-17 15:18   ` Shawn O. Pearce [this message]
2009-02-17 16:13     ` Jacob Helwig
2009-02-17 16:44       ` Johannes Schindelin
2009-02-17 17:09         ` Shawn O. Pearce
2009-02-17 21:06         ` Jacob Helwig
2009-02-18  0:13           ` thestar
2009-02-17 18:53       ` Boyd Lynn Gerber
2009-02-17  9:01 ` Gerrit Pape
2009-02-17 15:13   ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090217151838.GI18525@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=lznuaa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.