All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Does lm-sensors support chassis intrusion for
Date: Tue, 17 Feb 2009 19:52:07 +0000	[thread overview]
Message-ID: <20090217205207.4e956073@hyperion.delvare> (raw)
In-Reply-To: <f188924b0902150713q43addf9g94851a4d581b411e@mail.gmail.com>

Hi Michael,

On Tue, 17 Feb 2009 08:08:04 -0500, Michael Hampton wrote:
> I'm also interested in chassis intrusion (not to mention having my
> Winbond W83667HG chip fully supported in hwmon.c; see my previous
> message to the list on that topic). I'd like to contribute, but I admit

I have reviewed the patch adding support for the W83667HG chip, and had
some objections. It's now up to the patch author to answer them and
submit a new patch...

> I'm better at coding a standard than designing one. What does this
> standard need to look like?

Basically, a new entry in Documentation/hwmon/sysfs-interface. An entry
in this file consists in:
* A file name, wisely chosen to fit in the rest of the interface, be
  non-ambiguous and allow for future extensions. I can't think of any
  obvious extension in the case of the chassis intrusion detection, but
  it doesn't hurt to think about it for a moment. For example, could
  there be chips with more than one chassis intrusion detection sensor?
* Possible values for that file, with their meaning.
* Whether this file can be written to, what should be written and what
  happens when you do.

Looking at how some drivers implemented it in the absence of a standard
(as far as I can see: adm9240, w83792d and w83793) may provide
interesting suggestions. Looking at other chips which support the
feature even though their driver doesn't yet may be useful as well.

I can add you to the Cc list of ticket #2370 if you want.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2009-02-17 19:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-15 15:13 [lm-sensors] Does lm-sensors support chassis intrusion for Fintek Fred .
2009-02-16  9:43 ` [lm-sensors] Does lm-sensors support chassis intrusion for Jean Delvare
2009-02-17 10:53 ` Jean Delvare
2009-02-17 12:40 ` Fred .
2009-02-17 13:08 ` [lm-sensors] Does lm-sensors support chassis intrusion Michael Hampton
2009-02-17 19:41 ` [lm-sensors] Does lm-sensors support chassis intrusion for Jean Delvare
2009-02-17 19:52 ` Jean Delvare [this message]
2009-02-17 22:18 ` Fred .

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090217205207.4e956073@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.