From: Matthias Fuchs <mfuchs@ma-fu.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support
Date: Wed, 18 Feb 2009 07:46:54 +0100 [thread overview]
Message-ID: <200902180746.57288.mfuchs@ma-fu.de> (raw)
In-Reply-To: <200902171554.14147.matthias.fuchs@esd.eu>
Hi Stefan,
> On Tuesday 17 February 2009 15:19, Stefan Roese wrote:
> > On Sunday 15 February 2009, Matthias Fuchs wrote:
> > > This patch fixes coding style for PMC405 board support.
> > > Also some unneeded features/code is removed.
> >
> > Please find some comments below.
> >
> > > + out32(GPIO0_TCR, CONFIG_SYS_FPGA_PRG | CONFIG_SYS_FPGA_CLK | \
> > > + CONFIG_SYS_FPGA_DATA | CONFIG_SYS_XEREADY);
> >
> > I suggest to switch to using the out_be32()/in_be32() accessor functions
> > instead. I am aware that many other 4xx boards still use the "wrong" accessor
> > functions for initial GPIO configuration. I'll try to change this soon.
>
> You are right I missed these. I will update the patch and resend.
> I will also fix the other esd boards in the next days.
please take a look at my 2nd patch ("Update PMC405 ...."). It does the
requested accessor fixes. So my first patch does nothing by style cleanup while
the 2nd one brings some updates. I tried not to mix up beautyfication with
functional code changes :-) So please keep these patches as they are :-)
Matthias
next prev parent reply other threads:[~2009-02-18 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 21:26 [U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support Matthias Fuchs
2009-02-17 14:19 ` Stefan Roese
2009-02-17 14:54 ` Matthias Fuchs
2009-02-17 15:05 ` Stefan Roese
2009-02-18 6:46 ` Matthias Fuchs [this message]
2009-02-18 13:02 ` Stefan Roese
2009-02-18 13:04 ` Stefan Roese
2009-02-18 13:11 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902180746.57288.mfuchs@ma-fu.de \
--to=mfuchs@ma-fu.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.