From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754091AbZBRTlT (ORCPT ); Wed, 18 Feb 2009 14:41:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751832AbZBRTlK (ORCPT ); Wed, 18 Feb 2009 14:41:10 -0500 Received: from outbound-mail-132.bluehost.com ([67.222.39.22]:43003 "HELO outbound-mail-132.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751379AbZBRTlJ (ORCPT ); Wed, 18 Feb 2009 14:41:09 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org; h=Received:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id:X-Identified-User; b=t7RAldcYEx4xcKY/o0hBCIwI/Uh4p++yHreeS1AIOXT5LWc73MRdr6IJN/HHC5AlnizLEn4niEzSJxKj4uZMBNlvTbBBa8D/pa5+zA8SxEgK+OgUUY40eiwh2ohBIWK8; From: Jesse Barnes To: James Bottomley Subject: Re: ACPI hotplug panic with current git head Date: Wed, 18 Feb 2009 11:41:06 -0800 User-Agent: KMail/1.9.10 Cc: Kenji Kaneshige , LKML References: <1231604250.3642.33.camel@localhost.localdomain> <200902181059.26779.jbarnes@virtuousgeek.org> <1234984088.3225.44.camel@localhost.localdomain> In-Reply-To: <1234984088.3225.44.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902181141.06997.jbarnes@virtuousgeek.org> X-Identified-User: {642:box128.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 75.111.27.49 authed with jbarnes@virtuousgeek.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, February 18, 2009 11:08 am James Bottomley wrote: > On Wed, 2009-02-18 at 10:59 -0800, Jesse Barnes wrote: > > On Monday, February 16, 2009 9:10 pm Kenji Kaneshige wrote: > > > Jesse Barnes wrote: > > > > On Wednesday, January 28, 2009 3:47 am Kenji Kaneshige wrote: > > > >> I made several patches to fix the wrong assumption described > > > >> above. It is very difficult for me to check all the code that > > > >> refers pci_bus->self. So I checked include/linux/pci-acpi.h and > > > >> the code under drivers/pci/ only. And I made patches for the code > > > >> like below: > > > >> > > > >> - The code that clearly chooses host bridge operation or > > > >> PCI-to-PCI bridge operation based on pci_bus->self. > > > >> > > > >> - The code that might cause endless loop if pci_bus->self is > > > >> not NULL on the PCI root bus. > > > > > > > > Kenji-san, can you re-send these to my private mail so I can apply > > > > them? (Outlook/Exchange can't let plain text through without > > > > molesting it for some reason.) > > > > > > > > Thanks, > > > > > > Sure. Resending the following patches. I made those patches against > > > 2.6.29-rc2. I've confirmed they can be applied to 2.6.29-rc5. > > > > > > - [PATCH 1/8] PCI/ACPI: fix wrong assumption in > > > acpi_pci_get_bridge_handle - [PATCH 2/8] PCI/ACPI: fix wrong assumption > > > in > > > acpi_find_root_bridge_handle - [PATCH 3/8] PCI hotplug: fix wrong > > > assumption in acpi_get_hp_params_from_firmware - [PATCH 4/8] PCI > > > hotplug: fix wrong assumption in acpi_get_hp_hw_control_from_firmware - > > > [PATCH 5/8] PCI: fix wrong assumption in pci_find_upstream_pcie_bridge > > > - [PATCH 6/8] PCI: fix wrong assumption in pci_read_bridge_bases > > > - [PATCH 7/8] PCI: fix wrong assumption in pci_get_interrupt_pin > > > - [PATCH 8/8] PCI: fix wrong assumption in pci_common_swizzle > > > > James have you tested this set? I didn't see your tested-by in the > > changelogs... Just want to make sure if I'm going to send these to Linus > > for 2.6.29. > > Um ... no. I have enough trouble picking up my own patches from email. > Is there a git tree of this? I can pull that in to the box in question > if so. Just pushed the set to the hotplug-test branch of my PCI repo: git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6 hotplug-test -- Jesse Barnes, Intel Open Source Technology Center