All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Geoff Levand <geoffrey.levand@am.sony.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 1/7] tracing/function-graph-tracer: make arch generic push pop functions
Date: Wed, 18 Feb 2009 13:53:34 +0100	[thread overview]
Message-ID: <20090218125334.GA1300@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0902172243550.1360@gandalf.stny.rr.com>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 18 Feb 2009, Ingo Molnar wrote:
> 
> > 
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
> > 
> > > Ingo,
> > > 
> > > This patch is to make function graph arch generic. But since 
> > > the PowerPC changes depend on it, we want to push it through 
> > > the PowerPC tree. But since it touches x86 code, can you give 
> > > an Acked-by to it?
> > 
> > hm, but it's all ftrace bits. Could this go through the tracing 
> > tree? That's how it's generally done for most cross-arch 
> > subsystems. By having it in a separate tree we risk conflicts 
> > and various logistics problems. It's not like the PPC tree is 
> > modifying its ftrace.c file all that frequently, right?
> 
> Ingo,
> 
> How about this. We could incorporate some of the power of git. 
> I could make a separate branch based off of Linus's 2.6.29-rc5 
> announcement, and apply just this patch (the ftrace generic 
> and x86 change). If you give me your Acked-by, I'll add that 
> too.
> 
> This way, both you and Ben could pull from this branch to get 
> the one change. When it goes upstream, because it has the same 
> SHA1, git could easily resolve it.

Sure, that's fine too - if the separate tree is semantically 
meaningful. If it pulls in too many ftrace prerequisites i doubt 
it's appropriate for the PPC tree.

	Ingo

  reply	other threads:[~2009-02-18 12:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13  5:23 [PATCH 0/7] [git pull] powerpc function graph tracer Steven Rostedt
2009-02-13  5:23 ` [PATCH 1/7] tracing/function-graph-tracer: make arch generic push pop functions Steven Rostedt
2009-02-17  4:49   ` Steven Rostedt
2009-02-18  1:00     ` Ingo Molnar
2009-02-18  1:24       ` Steven Rostedt
2009-02-18  3:12         ` Benjamin Herrenschmidt
2009-02-18  3:48       ` Steven Rostedt
2009-02-18 12:53         ` Ingo Molnar [this message]
2009-02-18 17:29           ` Steven Rostedt
2009-02-13  5:24 ` [PATCH 2/7] powerpc64: port of the function graph tracer Steven Rostedt
2009-02-13  5:24 ` [PATCH 3/7] powerpc64, tracing: add function graph tracer with dynamic tracing Steven Rostedt
2009-02-13  5:24 ` [PATCH 4/7] powerpc64, ftrace: save toc only on modules for function graph Steven Rostedt
2009-02-13  5:24 ` [PATCH 5/7] powerpc32, ftrace: save and restore mcount regs with macro Steven Rostedt
2009-02-13  5:24 ` [PATCH 6/7] powerpc32, ftrace: port function graph tracer to ppc32, static only Steven Rostedt
2009-02-13  5:24 ` [PATCH 7/7] powerpc32, ftrace: dynamic function graph tracer Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090218125334.GA1300@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=fweisbec@gmail.com \
    --cc=geoffrey.levand@am.sony.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.