All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 2/2] tracing/function-graph-tracer: provide documentation for the function graph tracer
Date: Wed, 18 Feb 2009 15:01:50 +0100	[thread overview]
Message-ID: <20090218140150.GA31620@elte.hu> (raw)
In-Reply-To: <499ba227.077e420a.56d6.ffffc38b@mx.google.com>


btw., a minor trace-output observation. We currently have this 
default output:

# tracer: function_graph
#
# CPU  DURATION                  FUNCTION CALLS
# |     |   |                     |   |   |   |

 0)               |  sys_open() {
 0)               |    do_sys_open() {
 0)               |      getname() {
 0)               |        kmem_cache_alloc() {
 0)   1.382 us    |          __might_sleep();
 0)   2.478 us    |        }

Wouldnt this tweaked version look even nicer:

#
# [ tracer: function_graph ]
#
 CPU)  <duration>   |  <function-name>
 ..............................................
   0)               |  sys_open() {
   0)               |    do_sys_open() {
   0)               |      getname() {
   0)               |        kmem_cache_alloc() {
   0)   1.382 us    |          __might_sleep();
   0)   2.478 us    |        }


Changes:

 1) Added an empty '#' line to the head. Looks nicer because 
    the comment is now symmetric.

 2) Shifted of the CPU field two positions to the left. Better 
    for paste-ability and makes the 'CPU)' header fit as well.

 3) Changed the field description in the header portion to a 
    standard <field> notation.

 4) added the '....' line to create a table.

Hm?

	Ingo

  reply	other threads:[~2009-02-18 14:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18  5:35 [RFC][PATCH 2/2] tracing/function-graph-tracer: provide documentation for the function graph tracer Frederic Weisbecker
2009-02-18 14:01 ` Ingo Molnar [this message]
2009-02-18 15:58   ` Frederic Weisbecker
2009-02-18 16:10     ` Ingo Molnar
2009-02-19  4:09       ` Frederic Weisbecker
2009-02-18 17:30 ` Steven Rostedt
2009-02-19 12:25   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090218140150.GA31620@elte.hu \
    --to=mingo@elte.hu \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.