From: "Shawn O. Pearce" <spearce@spearce.org>
To: Constantine Plotnikov <constantine.plotnikov@gmail.com>
Cc: Sverre Rabbelier <srabbelier@gmail.com>, git@vger.kernel.org
Subject: Re: [JGIT PATCH v2] Fixed QuotedStringGitPathStyleTest.testDequote_OctalAll test that generated incorrect UTF-8 escape sequences
Date: Wed, 18 Feb 2009 07:46:20 -0800 [thread overview]
Message-ID: <20090218154620.GA22848@spearce.org> (raw)
In-Reply-To: <85647ef50902161050i43b478d4kb7faaa211dee727d@mail.gmail.com>
Constantine Plotnikov <constantine.plotnikov@gmail.com> wrote:
> The test was failing on the system that use a encoding different
> from ISO-8859-1. The reason was that invalid UTF-8 bytes were
> generated for codepoints greater than U+7F, and in this case
> the method RawParseUtils.decodeNoFallback falls backs to the
> default system encoding.
>
> Signed-off-by: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
Thanks.
> The bug was causing failure for the maven build on the windows
> environment that uses Cp1251 as a system encoding. However the test
> worked from Eclipse until I have specified jvm option
> -Dfile.ecoding=Cp1251, in the test case started to fail in Eclipse as
> well.
--
Shawn.
prev parent reply other threads:[~2009-02-18 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 18:50 [JGIT PATCH v2] Fixed QuotedStringGitPathStyleTest.testDequote_OctalAll test that generated incorrect UTF-8 escape sequences Constantine Plotnikov
2009-02-18 15:46 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218154620.GA22848@spearce.org \
--to=spearce@spearce.org \
--cc=constantine.plotnikov@gmail.com \
--cc=git@vger.kernel.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.