All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: hch@infradead.org, rth@twiddle.net, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alpha: binfmt_aout fix
Date: Wed, 18 Feb 2009 15:52:31 -0800	[thread overview]
Message-ID: <20090218155231.8b8c8b9f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090217114054.GA26176@jurassic.park.msu.ru>

On Tue, 17 Feb 2009 14:40:56 +0300
Ivan Kokshaysky <ink@jurassic.park.msu.ru> wrote:

> On Tue, Feb 17, 2009 at 06:08:42AM -0500, Christoph Hellwig wrote:
> > I think the proper fix for this is to make sure newly registered
> > binfmts are added to the tail of the list, not the front.
> 
> Yes, I was thinking about that. But then I need to make sure
> that alpha binfmt_loader is registered first, which is not
> possible at the moment as binfmts get registered at core_initcall
> level.
> If it's acceptable to change binfmts initcall level to, say,
> fs_initcall, then changing list_add() to list_add_tail() would
> certainly work fine here.
> 

It would make sense to register the core, default handlers first and
to permit arch-specific handlers to then override (or to front-end) the
core handlers.

But that sounds a bit risky for 2.6.29.  Is this fix needed in 2.6.29? 
If so, perhaps we should merge version 1 as a temporary thing.  But if
so, please let's not do the temporary-thing-which-hangs-around-forever thing?

  reply	other threads:[~2009-02-18 23:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17 10:49 [PATCH] alpha: binfmt_aout fix Ivan Kokshaysky
2009-02-17 11:08 ` Christoph Hellwig
2009-02-17 11:40   ` Ivan Kokshaysky
2009-02-18 23:52     ` Andrew Morton [this message]
2009-02-19  9:40       ` Ivan Kokshaysky
  -- strict thread matches above, loose matches on Subject: below --
2009-04-24 14:47 Ivan Kokshaysky
2009-04-24 15:05 ` Al Viro
2009-04-24 15:46   ` Ivan Kokshaysky
2009-04-24 20:19     ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090218155231.8b8c8b9f.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rth@twiddle.net \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.